Skip to content

tf2ss() does not seem to work for static gains #81

Description

@MauriceRienks

Creating a state space object of a static gain using tf2ss results in the ValueError: A must be square.

For example: tf2ss([1.],[1.])

Activity

  1. changed the title [-]tf() and tf2ss() do not seem to work for static gains[/-] [+]tf2ss() does not seem to work for static gains[/+] on Mar 21, 2016
  2. cwrowley commented on Mar 21, 2016

    @cwrowley
    Contributor

    I just verified this for tf2ss (using slycot)--definitely looks like a bug. Note that there are two cases that may happen when you call tf2ss, depending on whether slycot is installed. In fixing this bug, it would be good to add tests that test both versions (with and without slycot).

  3. slivingston commented on Feb 2, 2017

    @slivingston
    Member

    The case of static gains when Slycot is installed is now handled, given changes from python-control/Slycot#5, which will be in the next release of Slycot.

  4. slivingston commented on Feb 15, 2017

    @slivingston
    Member

    fixed in PR #129, changes from which are now in master branch and will appear in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions