control.forced_response argument T #586

Activity

1. bnavigator commented on Mar 24, 2021

   

   bnavigator

   on Mar 24, 2021

   Last edited by bnavigator

   Contributor

   More actions

   • For a discrete-time system , the time vector should be optional in the forced response (as stated in the documentation).

   Automatic timevector calculation only works if the sys has dt specified. Should be stated more explicitly in the documentation and a better error message should be provided.

   Plus, there is a bug in drss. It should return a system with dt=True, but the returned system has dt=0.

   • Also, the default value of return_x is stated to be True in the docstring, but it is None (False?) in the code.

   Agreed, this is a bug an error in the documentation. Since 0.9.0 the default value of config.defaults['forced_response.return_x'] is False.
2. bnavigator

   self-assigned this

   on Mar 24, 2021
3. bnavigator

   linked a pull request that will close this issueimprove forced_response and its documentation #588on Mar 30, 2021
4. bnavigator

   closed this as completedin #588on Apr 2, 2021