Activity

1. bnavigator commented on Jan 27, 2020

   

   bnavigator

   on Jan 27, 2020

   Contributor

   More actions

   Yes the num and den arrays are sized according to the order of the denominator

   python-control/control/xferfcn.py

   Lines 900 to 906 in 66bee9d

   	# figure out maximum number of poles, for sizing the den
   	maxindex = max([len(p) for p in poles])
   	den = zeros((self.inputs, maxindex + 1), dtype=float)
   	num = zeros((max(1, self.outputs, self.inputs),
   	max(1, self.outputs, self.inputs),
   	maxindex + 1),
   	dtype=float)

   This could be extended to use the maximum of numerator and denominator, but I am not sure TD04AD will handle this, as it likely expects a proper transfer function? The documenation of TD04AD seems to imply that always denorder > numorder.

   _common_den() should not fail with a ValueError though. A check and proper exception should be raised, or a return of the correct num and den and a warning display.

   👍React with 👍1Reacted by Rajab Legnain
2. rlegnain commented on Jan 28, 2020

   

   rlegnain

   on Jan 28, 2020

   Author

   More actions

   I think a return of num and den with warning message will be good.

   Thanks
3. murrayrm

   added this to the 0.8.4 milestone on Mar 21, 2020
4. murrayrm

   self-assigned this

   on Mar 22, 2020
5. murrayrm commented on Jul 11, 2020

   

   murrayrm

   on Jul 11, 2020

   Member

   More actions

   Fixed in PR #370
6. murrayrm

   closed this as completedon Jul 11, 2020