Repository navigation
non-intuitive Time-Domain Simulation functions behavior #239
Description
Activity
It is just giving you back the time array but since the sampling time of the system doesn't match the time increment it is resampling the bounds.
That's right.
However, this behavior is not intuitive to users. I would prefer it to be the actual time-array that is used to compute the impulse response. This information can be used, say, for plotting. Also, with the current behavior, the returned time-array T does not convey any information.
I agree that this behavior is non-intuitive and probably incorrect. Marking as a bug to be fixed in the next release.
I did a bit of looking into this. Some observations and issues:
-
The 'bug' in this code is something that is apparently inherited from the
scipy.signal.dlsim(), which is whatstep_response()eventually calls (through a call toforced_response()). In particular, it appears that if you passdlsim()a time vector that doesn't match the sampling time, it doesn't generate an error and, furthermore, it returns whatever you passed it (same behavior as what was noticed here). -
There is a further inconsistency in the way that
T=Noneis handled in thecontrolsimulation functions for discrete time systems: the time vector that is generated will havedt=1independent of what the actually sampling time for the system is. -
There may also be some issues with the way that the default response time is determined when you pass
T=Nonefor discrete time systems. Forstep_response()andinitial_response()this is supposed to be based on the dynamics matrixA. This uses the_default_response_times()function fromscipy.signal.ltisys, but I believe that function assumes continuous time (need to check).
I think that the correct behavior for discrete time systems is the following (which would match MATLAB):
- The values of the output argument
Tshould always match the times at which the corresponding outputsYare obtained. This is consistent with the idea that you plot the outputs of a simulation function by using commands of the form
t, y = step_response(sys) plot(t, y)-
If you pass an explicit set of sampling times for a discrete time system, the time increment should match the sampling time (with
dt=Truebeing interpreted as a sampling time of 1). In this case, the output argumentTwill match the input argumentT. -
If you omit the sampling time, the value of
Twill be determined based on either the input signal (forforced_response()or the time constants coming from the system dynamics. In either case, the difference between time points should be equal to the sampling time of the system (or 1 ifdt=True). -
For
forced_response(), the length of the input vectorUshould match the length of the time vectorT.
The good news is that a relatively modest set of changes are required to fix all of these things up. Comments welcome on whether I am missing anything, but I'll start putting together test cases for the properties above and then updating the code.
-
Hello,
@murrayrm :After stumbling upon this issue in 0.8.1, I installed 0.8.2, which I believe only partly solves the issue:
When runningT_heat = 1 K_heat = 5 num_heat = [K_heat] den_heat = [T_heat, 1] LTI_FO_model = control.tf(num_heat, den_heat) LTI_FO_modeld = LTI_FO_model.sample(Ts=0.25) (T, yout) = control.step_response(LTI_FO_model) (Td, youtd) = control.step_response(LTI_FO_modeld) plt.plot(T, yout) plt.plot(Td,youtd) plt.show()I am still having the problem that youtd is 2D while T is 1D. The error reads
x and y must have same first dimension, but have shapes (9,) and (1, 9)Will look into this and see if I can generate a unit test that exhibits the error, so that we can nail this one down.
Hi, I notice that the simulation functions:
step_response,impulse_response, for discrete time systems is not very intuitive, and is also inconsistent with matlab's behavior (I sort of have the habit of checking matlab documentation for a python-control function if there are suprises).Consider this snippet
we would expect
Tto be the time instances that correspond to values iny(matlab behavior), but it turns out not the case. I gotT.shape = (25,)whiley.shape=(1, 10). The same behavior can be observed for other time-domain functions for discrete-time systems (continuous-time systems are alright).