Repository navigation
provide more prominent interface for lft linear fractional transformation #1156
Description
Activity
If someone wants to take this on, there are a couple of other enhancements that it would be good to address at the same time:
- The current docstring for
StateSpace.lftdoesn't provide any information on what the function does, it just references a textbook and (tries to) link to the MATLAB documentation (the link is broken). It would be better to have a self-contained docstring. - The current method does not preserve signal names for the inputs and outputs of the transformed system.
- The current method does not allow renaming of the system, inputs, outputs, and states. This should be done in the standard way of all system creation functions.
- It might be useful to create an
lftfunction in thecontrolnamespace with signaturelft(sys1, sys2, [nu, ny], **kwargs). Ifsys1andsys2areStateSpaceobjects, the current method could be used. Otherwise, theinterconnectfunction could be called to create the system for any I/O system. - Narrative documentation should be placed in the User Guide, either in Chapter 3 (Linear Systems) or Chapter 6 (Interconnected I/O Systems). The latter probably makes the most sense, perhaps in the Block Diagram Algebra section.
- Function documentation should be placed in the Reference Manual, likely in the System Interconnection section of the Function Reference chapter.
Note: References to sections in the documentation are relatively to the current main branch, which was reorganized in #1094.
- The current docstring for
found another function not in the function reference
singular_values_plotsingular_values_plotis in the function reference for the current main branch (which will become 0.10.2):https://python-control.readthedocs.io/en/latest/functions.html#control-system-analysis
so it's easier to find or know about. or explain in the function reference that there are other more functions available through state space instances. so you at least know where else to look for capabilities.