Skip to content

td04ad with rowcol = 'C' fails in 4 out of 5 testcases #251

Closed
Closed
td04ad with rowcol = 'C' fails in 4 out of 5 testcases#251

Description

@Peter3579
Peter3579
opened on Oct 25, 2025

When compiling slycot on NixOS (Linux), 4 out of 5 "td04ad_c" testcases fail. Ignoring this (and nevertheless installing slycot) leads to 170 failing testcases in the control package.

Both, v0.6.0 and master, show the same issue. I used SLICOT v5.9.

=========================== short test summary info ============================
FAILED ../../nix/store/4i61izh6bxdjz498fq28j2149dh5m2bk-python3.13-slycot-0.6.0/lib/python3.13/site-packages/slycot/tests/test_td04ad.py::test_staticgain - slycot.exceptions.SlycotParameterError: The following argument had an illeg...
FAILED ../../nix/store/4i61izh6bxdjz498fq28j2149dh5m2bk-python3.13-slycot-0.6.0/lib/python3.13/site-packages/slycot/tests/test_td04ad.py::test_td04ad_static - slycot.exceptions.SlycotParameterError: The following argument had an illeg...
FAILED ../../nix/store/4i61izh6bxdjz498fq28j2149dh5m2bk-python3.13-slycot-0.6.0/lib/python3.13/site-packages/slycot/tests/test_td04ad.py::test_mixfeedthrough - slycot.exceptions.SlycotParameterError: The following argument had an illeg...
FAILED ../../nix/store/4i61izh6bxdjz498fq28j2149dh5m2bk-python3.13-slycot-0.6.0/lib/python3.13/site-packages/slycot/tests/test_td04ad.py::test_tfm2ss_6 - slycot.exceptions.SlycotParameterError: The following argument had an illeg...
================== 4 failed, 132 passed, 2 warnings in 1.51s ===================

All these tests fail with:
E slycot.exceptions.SlycotParameterError: The following argument had an illegal value: dcoeff

Activity

  1. roryyorke commented on Oct 26, 2025

    @roryyorke
    roryyorke
    on Oct 26, 2025
    Collaborator

    We build against a custom version of SLICOT, currently https://github.com/python-control/SLICOT-Reference/tree/slycot-changes . This is mentioned in our README: https://github.com/python-control/Slycot?tab=readme-ov-file#get-it-from-github-archives , but we could be clearer that this isn't vanilla upstream SLICOT.

    Our changes include diffs to TD04AD.f. I don't see anything in SLICOT issues about this, assume we never filed an issue with them --- I'll make a note to do so.

  2. Peter3579 commented on Oct 26, 2025

    @Peter3579
    Peter3579
    on Oct 26, 2025
    Author

    Thanks a lot for pointing out that a patched version of SLICOT-Reference is needed. Using rev= "795051cbc2a1d4766753e9ab3bac13eaf731f8d6"; did the trick. The tests pass now.

  3. Peter3579
    closed this as completedon Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions