kw_only doesn't work with mypy #473

Activity

1. euresti commented on Dec 16, 2018

   

   euresti

   on Dec 16, 2018

   Contributor

   More actions

   Hmm. This feature definitely didn't exist when I wrote the plugin. Maybe I'll have time over the break to work on this.
2. quinor commented on Dec 16, 2018

   

   quinor

   on Dec 16, 2018

   Author

   More actions

   From my understanding it makes mypy unusable with attrs right now, or is there a workaround that doesn't require too much code?
3. wsanchez

   added

   Bug

   on Dec 17, 2018
4. euresti commented on Dec 17, 2018

   

   euresti

   on Dec 17, 2018

   Contributor

   More actions

   Sadly, for now the only way around it is to # type: ignore those lines.
5. hynek commented on Dec 18, 2018

   

   hynek

   on Dec 18, 2018

   Member

   More actions

   This should be a bug on the mypy tracker no?
6. dmfigol commented on Jan 8, 2019

   

   dmfigol

   on Jan 8, 2019

   Last edited by dmfigol

   More actions

   @euresti
   thanks for the mypy plugin!
   The latest Pycharm 2018.3.2 still does not like kw_only. Inspection throws an error on the decorator line and whenever an object is created:

   1. Code: @attr.s(auto_attribs=True, repr=False, kw_only=True)
      Pycharm inspection:

   Unexpected argument(s). Possible callees: attrs(maybe_cls: None=..., these: Optional[Dict[str, Any]]=..., repr_ns: Optional[str]=..., repr: bool=..., cmp: bool=..., hash: Optional[bool]=..., init: bool=..., slots: bool=..., frozen: bool=..., str: bool=..., auto_attribs: bool=...) attrs(maybe_cls: _C, these: Optional[Dict[str, Any]]=..., repr_ns: Optional[str]=..., repr: bool=..., cmp: bool=..., hash: Optional[bool]=..., init: bool=..., slots: bool=..., frozen: bool=..., str: bool=..., auto_attribs: bool=...)
   

   2. Code: Car(name="Lotus", year=2001) # object created with attrs + kw_only
      Pycharm inspection:
      Unexpected argument(s). Possible callees: object(self: object) object.__new__(cls: object)

   It seems that attrs stub in typeshed is missing kw_only?
   .../typeshed/third_party/2and3/attr/__init__.pyi

   @overload
   def attrs(maybe_cls: _C,
             these: Optional[Dict[str, Any]] = ...,
             repr_ns: Optional[str] = ...,
             repr: bool = ...,
             cmp: bool = ...,
             hash: Optional[bool] = ...,
             init: bool = ...,
             slots: bool = ...,
             frozen: bool = ...,
             str: bool = ...,
             auto_attribs: bool = ...) -> _C: ...
   @overload
   def attrs(maybe_cls: None = ...,
             these: Optional[Dict[str, Any]] = ...,
             repr_ns: Optional[str] = ...,
             repr: bool = ...,
             cmp: bool = ...,
             hash: Optional[bool] = ...,
             init: bool = ...,
             slots: bool = ...,
             frozen: bool = ...,
             str: bool = ...,
             auto_attribs: bool = ...) -> Callable[[_C], _C]: ...
   

   UPDATE: it seems it is already fixed in the typeshed. I didn't notice, sorry
7. euresti commented on Jan 9, 2019

   

   euresti

   on Jan 9, 2019

   Contributor

   More actions

   Fixed here:
   python/typeshed#2720
   And here:
   python/mypy#6107

   ❤️React with ❤️1Reacted by Hynek Schlawack
8. euresti

   closed this as completedon Jan 9, 2019