Repository navigation
scripts/create_baseline_stubs.py instructions are outdated #8837
Description
I would prefer:
1. Manually review the generated stubs in {stub_dir}
2. Run tests locally if you want (see CONTRIBUTING.md)
3. Commit the changes on a new branch and create a typeshed PR
The CI will check everything anyway, and is set up so that you don't have to run anything locally. This would also be consistent with CONTRIBUTING.md.
Originally posted by @Akuli in #8686 (comment)
Activity
srittau commentedon Oct 4, 2022
One problem with the generated stubs were overzealous re-exports. Is this still an issue? In that case we should probably mention it. But +1 from me.
AlexWaygood commentedon Oct 4, 2022
@Avasam has a proposed fix for this included as part of #8798 (edit: now merged).
AlexWaygood commentedon Oct 4, 2022
This is definitely still an issue. But @hauntsaninja mentioned to me recently that this can probably be fixed just by passing the
--export-lessargument to stubgen. We should see if that fixes the problem — if so, there's no need to mention it to contributors in thecreate_baseline_stubs.pyinstructions.