HTTPSConnection.__init__(port=) incorrectly annotated as str | None for 3.12

This was introduced in #10392.

As far as I can tell by reading the code, it's only ever valid to give an integer or None. This matches the (correct) typeshed annotations for HTTPConnection and versions before Python 3.12. The problem seems to be specific to HTTPSConnection and Python 3.12.

Hm, indeed it looks like int for port is correct. Please, send a PR :)

typeshed/stdlib/http/client.pyi

Lines 151 to 156 in 06d0151

    
           port: int 
        
           sock: socket | Any  # can be `None` if `.connect()` was not called 
        
           def __init__( 
        
               self, 
        
               host: str, 
        
               port: int | None = None,

Implementation: https://github.com/python/cpython/blob/bfc6d91c784c428c6f5c706a316cdce9140c4753/Lib/http/client.py#L920

Please, send a PR :)

tada: #11058

stdlib: HTTPSConnection(port=) is int|None

stdlib: HTTPSConnection(port=) is int|None (#11058)

Navigation Menu

Repository navigation

`HTTPSConnection.init(port=)` incorrectly annotated as `str | None` for 3.12 #11057

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	port: int
	sock: socket \| Any # can be `None` if `.connect()` was not called
	def __init__(
	self,
	host: str,
	port: int \| None = None,

HTTPSConnection.__init__(port=) incorrectly annotated as str | None for 3.12 #11057

Description

Activity

sobolevn commented on Nov 22, 2023

allisonkarlitskaya commented on Nov 22, 2023

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

`HTTPSConnection.init(port=)` incorrectly annotated as `str | None` for 3.12 #11057