Skip to content

Commit 39a6689

Browse files
bluetechbluetech
committed
stdlib/2and3/builtins: change dict.fromkeys to classmethod
The referenced issue in mypy is fixed.
1 parent d539772 commit 39a6689

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

‎stdlib/2/__builtin__.pyi‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -996,12 +996,12 @@ class dict(MutableMapping[_KT, _VT], Generic[_KT, _VT]):
996996
def viewkeys(self) -> KeysView[_KT]: ...
997997
def viewvalues(self) -> ValuesView[_VT]: ...
998998
def viewitems(self) -> ItemsView[_KT, _VT]: ...
999-
@staticmethod
999+
@classmethod
10001000
@overload
1001-
def fromkeys(__iterable: Iterable[_T]) -> Dict[_T, Any]: ... # TODO: Actually a class method (mypy/issues#328)
1002-
@staticmethod
1001+
def fromkeys(cls, __iterable: Iterable[_T]) -> Dict[_T, Any]: ...
1002+
@classmethod
10031003
@overload
1004-
def fromkeys(__iterable: Iterable[_T], __value: _S) -> Dict[_T, _S]: ...
1004+
def fromkeys(cls, __iterable: Iterable[_T], __value: _S) -> Dict[_T, _S]: ...
10051005
def __len__(self) -> int: ...
10061006
def __getitem__(self, k: _KT) -> _VT: ...
10071007
def __setitem__(self, k: _KT, v: _VT) -> None: ...

‎stdlib/2and3/builtins.pyi‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -996,12 +996,12 @@ class dict(MutableMapping[_KT, _VT], Generic[_KT, _VT]):
996996
def viewkeys(self) -> KeysView[_KT]: ...
997997
def viewvalues(self) -> ValuesView[_VT]: ...
998998
def viewitems(self) -> ItemsView[_KT, _VT]: ...
999-
@staticmethod
999+
@classmethod
10001000
@overload
1001-
def fromkeys(__iterable: Iterable[_T]) -> Dict[_T, Any]: ... # TODO: Actually a class method (mypy/issues#328)
1002-
@staticmethod
1001+
def fromkeys(cls, __iterable: Iterable[_T]) -> Dict[_T, Any]: ...
1002+
@classmethod
10031003
@overload
1004-
def fromkeys(__iterable: Iterable[_T], __value: _S) -> Dict[_T, _S]: ...
1004+
def fromkeys(cls, __iterable: Iterable[_T], __value: _S) -> Dict[_T, _S]: ...
10051005
def __len__(self) -> int: ...
10061006
def __getitem__(self, k: _KT) -> _VT: ...
10071007
def __setitem__(self, k: _KT, v: _VT) -> None: ...

0 commit comments

Comments
 (0)