Skip to content

Should the menu be pinned like it was in 2.7? #8

Closed

Description

@JulienPalard

While working on the doc with @FGuillet and @BrunoMaugery we spotted some javascript updating the position of the menu, like to "pin" it on the screen while scrolling, like 2.7 is still doing. We though it was just broken, but do we want to keep this feature? It looks like it causes jiterring problems in 2.7 https://bugs.python.org/issue32393.

Activity

  1. theacodes commented on Jan 2, 2018

    @theacodes
    Collaborator

    i'm not a huge fan of pinning personally.

  2. septatrix commented on Feb 11, 2020

    @septatrix
    Contributor

    I personally like the pinning as it gives me the possibility to jump to another section even when im halfway through the page.
    Following a few redirects in the bug report you linked I was able to find this commit python/cpython@8ab24b2. Apparently this fixes the issue. However this is not yet implemented in this theme but we probably could simply apply this patch here.
    Does anyone know why there are apparently two different locations where this theme is maintained anyway?

  3. philg314 commented on Aug 1, 2022

    @philg314
    Contributor

    This has been implemented in #91 so this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions