Islington reports status check being a success but also reports ❌ when checks fail

I noticed this in python/cpython#94734 and this comment: python/cpython#94734 (comment)

The checks clearly fail:
https://github.com/python/cpython/pull/94734/checks

Islington reports the checks as both being a success but uses the emoji that's being used to indicate that the checks failed.

Relevant code seems to be:

miss-islington/miss_islington/status_change.py

Lines 102 to 112 in 6e5de75

    
           if title_match or is_automerge: 
        
               success = result["state"] == "success" and not any( 
        
                   elem in [None, "failure", "timed_out"] 
        
                   for elem in all_check_run_conclusions 
        
               ) 
        
               if leave_comment: 
        
                   if success: 
        
                       emoji = "✅" 
        
                   else: 
        
                       emoji = "❌" 
        
                   message = f"Status check is done, and it's a {result['state']} {emoji} ."

This seems rather straightforward so I'm not immediately sure what is broken here. Can there be some sort of race condition where result["state"] is "success" on L103 but has changed when we reach L112?

Oh no, I'm stupid. This is actually pretty straightforward. If result["state"] == "success" but there are timed out checks then the f-string will still use "success" even though the if success check fails.
That should be easily fixable. Working on a PR.

Interesting. I fixed this in #501 but it was re-caused by a faulty merge in #481. Goes to show the value of tests.

Navigation Menu

Repository navigation

Islington reports status check being a success but also reports ❌ when checks fail #564

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	if title_match or is_automerge:
	success = result["state"] == "success" and not any(
	elem in [None, "failure", "timed_out"]
	for elem in all_check_run_conclusions
	)
	if leave_comment:
	if success:
	emoji = "✅"
	else:
	emoji = "❌"
	message = f"Status check is done, and it's a {result['state']} {emoji} ."

Islington reports status check being a success but also reports ❌ when checks fail #564

Description

Activity

DanielNoord commented on Jul 11, 2022

jacobtylerwalls commented on Oct 9, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions