Skip to content

Build for unexisting translations are expectingly failing, should log it properly  #16

Closed

Description

@JulienPalard

The line shell_out("git -C {} checkout {}".format(directory, branch)) is throwing an exception as the 3.7 branch does not exists in french translation, this is expected and don't crash the script. it just don't compile the unexisting translation.

It should be reported nicely instead of logging a whole stacktrace: misreading it the first time make me though the 3.7 english build was failing.

I'm currently fixing this.

Thoughts: I should probably build an untranslated version using po files from a near version… so if a new version spawn, we don't wait for translators teams to push the branch to build the docs.

Activity

  1. changed the title [-]Build for 3.7 is failing due to unexisting 3.7 branch [/-] [+]Build for unexisting translations are expectingly failing, should log it properly [/+] on Jul 30, 2017
  2. JulienPalard commented on Aug 1, 2017

    @JulienPalard
    MemberAuthor

    I'm experimenting a "fallback" to the nearest translated version, it make sense in cases like: a new version spawn (say 3.7), but translatiors are laggy to create their 3.7 branch, docsbuild will use po files from their 3.6 branch (almost identical files so it will work) so everyone can see it, crawlers can start indexing it, and it's up to each translations to fork the branch when the feel it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions