Repository navigation
Introduce "type names" section to the style guide #1828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8935bce
Introduce "type names" section to the style guide
sirosen 1328257
Apply suggestion from @StanFromIreland
sirosen 3c5e2c7
Move "specific words" and "type names" down in page
sirosen e0faa0c
Add explicit anchor for style-guide links section
sirosen 81deaa3
Make the style-guide 'links' ref more usable
sirosen 86a969f
Reframe type names guide to allow more judgement
sirosen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line with my comment on the issue, could we add:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this proposed text, but feel that it has a degree of overlap with the last paragraph.
I'm going to try to integrate the two but intend to append this if I can't figure out a good combination.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The style guide as a whole could use a PEP-8 style note:
Specifically for class names in long discussion, perhaps this could mirror the guidance on links. The first occurrence should use
:class:; subsequent ones can use plain words if it's clear that it's still talking about the same thing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made an edit to weave these suggestions into the text, which required a little tuning of the first paragraph in addition to a larger change to the last.
The part which is most different from Ned's suggestion is this:
I mean for that to carry the message about "the author will need to exercise judgement" as well as the idea that, like links, you should first clarify the exact type and then exercise more freedom in how you write.
I'm very concerned with brevity for these docs, so I was trying to pack the ideas in very tightly, in the smallest reasonable number of words.