You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @mariehuynh, This looks like the sidebar open/close is not rendering properly on Android. I don't see the same behavior on Safari or Chrome when sized to mobile width.
Thanks for the research @mariehuynh. I'm glad you were able to reproduce. Your suggestion seems like it will work. We may also see if the fix should be contributed back to the Sphinx project.
I think it's best to fix this upstream on Sphinx. Once the patch has been tested and accepted upstream we can either apply it here directly, or wait for the next Sphinx release.
We also don't have a specific list of supported browsers (other than "the main ones"), but Sphinx might.
Activity
brettcannon commentedon May 16, 2018
Can you share a screenshot?
mariehuynh commentedon May 16, 2018
https://photos.app.goo.gl/Mab6VutMdXUTH8Ug2
brettcannon commentedon May 16, 2018
Looks like a French-style quote.
mariehuynh commentedon May 16, 2018
Probably just a 1-2 line CSS fix. I'll take a look when I get on a real machine.
willingc commentedon May 17, 2018
Hi @mariehuynh, This looks like the sidebar open/close is not rendering properly on Android. I don't see the same behavior on Safari or Chrome when sized to mobile width.
mariehuynh commentedon May 30, 2018
I reproduced the problem on Chromium on Debian, and Chrome on a Mac, by reducing the size of the window and then scrolling horizontally.
mariehuynh commentedon May 30, 2018
I don't see any CSS in this repo that affects this, and traced the problem back to the default CSS in Sphinx. We can override it via something like
div#sidebarbutton span {
position: sticky;
}
in tools/static/custom.css
willingc commentedon Jun 11, 2018
Thanks for the research @mariehuynh. I'm glad you were able to reproduce. Your suggestion seems like it will work. We may also see if the fix should be contributed back to the Sphinx project.
mariehuynh commentedon Jun 11, 2018
I can make the change and run some tests. Can you point me at your protocol for testing before submission? What browsers are officially supported?
ezio-melotti commentedon Sep 11, 2018
I think it's best to fix this upstream on Sphinx. Once the patch has been tested and accepted upstream we can either apply it here directly, or wait for the next Sphinx release.
We also don't have a specific list of supported browsers (other than "the main ones"), but Sphinx might.
hugovk commentedon Dec 23, 2022
Adding that here for future reference:
I've not seen this since we moved to Furo (#679), let's close this unless someone can still reproduce.