Skip to content

gh-91719: Reload opcode on unknown error so that C can optimize the dispatching in ceval.c #94364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 9 commits into from
Jun 30, 2022
Merged

gh-91719: Reload opcode on unknown error so that C can optimize the dispatching in ceval.c #94364

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f6833ca
Load opcode via next_instr
neonene Jun 28, 2022
70a1a9f
Comment
neonene Jun 28, 2022
a4c9722
Do the opcode reloading always, not just on Windows.
gvanrossum Jun 29, 2022
ba84e68
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 29, 2022
fa090e5
fix NEWS
neonene Jun 29, 2022
3ba3bf2
update NEWS
neonene Jun 30, 2022
a341d5e
update comment
neonene Jun 30, 2022
db0a6b3
Change NEWS to mention non-MSVC
neonene Jun 30, 2022
0ce3859
make comment generic
neonene Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5705,6 +5705,10 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, _PyInterpreterFrame *frame, int
_unknown_opcode:
#else
EXTRA_CASES // From opcode.h, a 'case' for each unused opcode
/* Load opcode for MSVC to optimize switch(opcode) separately.
Comment thread
gvanrossum marked this conversation as resolved.
Resolved
next_instr, which EXTRA_CASES do not increment, points
the current instruction here. */
opcode = _Py_OPCODE(*next_instr);
#endif
Comment thread
gvanrossum marked this conversation as resolved.
Resolved
fprintf(stderr, "XXX lineno: %d, opcode: %d\n",
_PyInterpreterFrame_GetLine(frame), opcode);
Expand Down