Skip to content

bpo-22602: Raise an exception in the UTF-7 decoder for ill-formed sequences starting with "+" #8741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 2 commits into from
Aug 19, 2018
Merged

bpo-22602: Raise an exception in the UTF-7 decoder for ill-formed sequences starting with "+" #8741

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d3153f
bpo-22602: Raise an exception in the UTF-7 decoder for ill-formed seq…
ZackerySpytz Aug 12, 2018
794faa9
Add a test for the "replace" error handler.
ZackerySpytz Aug 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/test/test_codecs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,6 +1020,7 @@ def test_errors(self):
(b'a+////,+IKw-b', 'a\uffff\ufffd\u20acb'),
(b'a+IKw-b\xff', 'a\u20acb\ufffd'),
(b'a+IKw\xffb', 'a\u20ac\ufffdb'),
(b'a+@b', 'a\ufffdb'),

@eamanu eamanu Aug 13, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will fail. Is that you want?

@ZackerySpytz ZackerySpytz Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The self.assertRaises() on line 1027 checks that a UnicodeDecodeError is raised with the "strict" error handler. Or did you mean something else?

@eamanu eamanu Aug 14, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I put the comment in the wrong line. I think that the test will fail on line 1029 self.assertEqual(raw.decode('utf-7', 'replace'), expected)

@ZackerySpytz ZackerySpytz Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you're mistaken.

@serhiy-storchaka serhiy-storchaka Aug 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add also tests for b'a+' and b'a+@'. It may be need to change the code for proper handling these cases.

]
for raw, expected in tests:
with self.subTest(raw=raw):
Expand Down