Skip to content

bpo-26133: Dont unsubscribe signals in UNIX even loop on interpreter shutdown #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asvetlov merged 5 commits into from
Dec 21, 2017
Merged

bpo-26133: Dont unsubscribe signals in UNIX even loop on interpreter shutdown #4956

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
756b93d
Dont unsubscribe signals in UNIX even loop on interpreter shutdown
asvetlov Dec 21, 2017
b2b4a7e
Add stacklevel 2 for raised message
asvetlov Dec 21, 2017
0a0b8c9
Add NEWS entry
asvetlov Dec 21, 2017
41a9f22
Fix notes
asvetlov Dec 21, 2017
628d68e
Add source-self
asvetlov Dec 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Lib/asyncio/unix_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,13 @@ def __init__(self, selector=None):

def close(self):
super().close()
for sig in list(self._signal_handlers):
self.remove_signal_handler(sig)
if not sys.is_finalizing():

@1st1 1st1 Dec 21, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if someone calls loop.close() twice? I guess self._signal_handlers.clear() is needed.

@asvetlov asvetlov Dec 21, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double warning will be shown obviously.
But it is very rare situation: most likely the loop will be closed by __del__.
Even atexit callbacks are called when sys.is_finalizing() is False.

@1st1 1st1 Dec 21, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, in this case I'd like to clear the list of signal handlers.

@asvetlov asvetlov Dec 21, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will make a postfix PR soon.

for sig in list(self._signal_handlers):
self.remove_signal_handler(sig)
else:
warinigs.warn(f"Closing the loop {self} on interpreter shutdown "

@vstinner vstinner Dec 21, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace {self} with {self!r}. See for example BaseEventLoop.close() resource warning.

f"stage, signal unsubsription is disabled",
stacklevel=2)

@vstinner vstinner Dec 21, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that stacklevel=2 is correct. Maybe remove it?

For the warning category, I hesitate to use ResourceWarning and pass source=self. ResourceWarning are quiet by default. It's maybe better to not pollute stdout with such warning?


def _process_self_data(self, data):
for signum in data:
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2017-12-21-11-08-42.bpo-26133.mt81QV.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Dont unsubscribe signals in asyncio UNIX event loop on interpreter shutdown.

@vstinner vstinner Dec 21, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be written "Don't", no?