Skip to content

bpo-40334: Support type comments #19780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 12 commits into from
Apr 30, 2020
Merged

bpo-40334: Support type comments #19780

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e17bb92
First steps towards supporting type comments
gvanrossum Apr 26, 2020
2e4126c
Support func_type_input in new parser
gvanrossum Apr 27, 2020
7b446fb
Support '# type: ignore <tag>'
gvanrossum Apr 28, 2020
ed95a14
Support per-argument type comments ('long form')
gvanrossum Apr 29, 2020
acb69b3
Fix segfault in long-form argument type comments
gvanrossum Apr 29, 2020
1e8f7fd
Fix failing test_ast by refactoring param rules
gvanrossum Apr 29, 2020
da253f3
Merge remote-tracking branch 'origin/master' into type-comments
gvanrossum Apr 29, 2020
86d9f69
Fix bug in add_type_comment()
gvanrossum Apr 29, 2020
c8a2888
Suggestions from code review
gvanrossum Apr 29, 2020
fd2794b
Refactoring some things in response to review
gvanrossum Apr 30, 2020
d081578
More thorough error checks in NEW_TYPE_COMMENT
gvanrossum Apr 30, 2020
fecd8e8
Add CHECK() around _PyPegen_seq_append_to_end() call
gvanrossum Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Parser/pegen/pegen.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ _PyPegen_add_type_comment(Parser *p, arg_ty a, char *tc)
if (tc == NULL) {
return a;
}
PyObject *tco = _PyPegen_new_type_comment(p, tc);
PyObject *tco = NEW_TYPE_COMMENT(tc);

@lysnikolaou lysnikolaou Apr 29, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't NEW_TYPE_COMMENT expect tc to be a Token *, i.e. that tc->bytes is a bytes object? I feel that NEW_TYPE_COMMENT would better be off as an inline function.

if (tco == NULL) {
return NULL;
}
Expand Down