Skip to content

bpo-30486: Allow setting cell value #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 10 commits into from
Jun 8, 2017
Merged

bpo-30486: Allow setting cell value #1840

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
83b5e62
Adds cell_set_contents.
lisroach May 28, 2017
9b4cfd2
Not using Py_SETREF bc it uses PyObject instead of PyCellObject.
lisroach May 28, 2017
244cb7e
Updates to use XSETREF. Adds docs, tests, and news update.
lisroach Jun 1, 2017
c5db387
cell_contents can be set to none. Update documentation.
lisroach Jun 2, 2017
02dbd0e
Updates test with return value and updates documentation.:
lisroach Jun 6, 2017
447cc10
Updates tests.
lisroach Jun 7, 2017
b22b945
Checks a value after deletion.
lisroach Jun 7, 2017
f11ace7
removes trailing whitespace from docs.
lisroach Jun 8, 2017
bd5e329
Adds back in *.
lisroach Jun 8, 2017
1f0ef6c
Merge branch 'master' into issue30486
serhiy-storchaka Jun 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Lib/test/test_funcattrs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,19 +100,16 @@ def f(): return a
c[0].cell_contents = 9
self.assertEqual(c[0].cell_contents, 9)

@serhiy-storchaka serhiy-storchaka Jun 3, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to check how setting and deleting cell_contents affects the local variable a.

self.assertEqual(f(), 9)

@serhiy-storchaka serhiy-storchaka Jun 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check a directly.

self.assertEqual(a, 9)

self.assertEqual(a, 9)
del c[0].cell_contents
try:

@serhiy-storchaka serhiy-storchaka Jun 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that you have copied an example from the above test, but this is too verbose. with self.assertRaises(ValueError): is much more compact.

c[0].cell_contents
except ValueError:
pass
else:
self.fail("shouldn't be able to read an empty cell")
try:
with self.assertRaises(NameError):

@serhiy-storchaka serhiy-storchaka Jun 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check a directly.

f()
except NameError:
pass
else:
self.fail("variable not deleted")

def test___name__(self):
self.assertEqual(self.b.__name__, 'b')
Expand Down