Skip to content

gh-149584: _remote_debugging: Stop rereading the base frame sentinel #159124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maurycy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-149584: _remote_debugging: Stop rereading the base frame sentinel #159124

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bde281
up
maurycy Oct 10, 2026
1a5fa06
komment
maurycy Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-10-10-13-35-08.gh-issue-149584.Yq2bF7.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Improve the performance of the Tachyon profiler by avoiding unnecessary remote
reads of the base frame sentinel. Patch by Maurycy Pawłowski-Wieroński.
5 changes: 5 additions & 0 deletions Modules/_remote_debugging/frames.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,11 @@ process_frame_chain(
}
assert(frame_count <= MAX_FRAME_CHAIN_DEPTH);

if (frame_addr == ctx->base_frame_addr
Comment thread
maurycy marked this conversation as resolved.
Resolved
&& !(unwinder->gc && frame_addr == ctx->gc_frame)) {
Comment thread
maurycy marked this conversation as resolved.
Resolved
break;
}

if (ctx->chunks && ctx->chunks->count > 0) {
parse_result = parse_frame_from_chunks(
unwinder, &frame, frame_addr, &next_frame_addr, &stackpointer, ctx->chunks);
Expand Down
Loading