Skip to content
Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/support/warnings_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def _filterwarnings(filters, quiet=False):
registry.clear()
# Because test_warnings swap the module, we need to look up in the
# sys.modules dictionary.
wmod = sys.modules['warnings']
wmod = sys.modules.get('warnings', warnings)
with wmod.catch_warnings(record=True) as w:
# Set filter "always" to record all warnings.
wmod.simplefilter("always")
Expand Down
29 changes: 29 additions & 0 deletions Lib/test/test_warnings_helper.py
Comment thread
mikemikimike marked this conversation as resolved.
Resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import sys
import unittest
from contextlib import contextmanager
from unittest.mock import patch

from test.support import warnings_helper


class WarningsHelperTests(unittest.TestCase):
def test_check_warnings_when_module_is_not_in_sys_modules(self):
warnings_module = sys.modules.pop("warnings", None)
try:
@contextmanager
def catch_warnings(*, record):
self.assertTrue(record)
yield []

with patch.object(
warnings_helper.warnings, "catch_warnings", catch_warnings
):
with warnings_helper.check_warnings(quiet=True):
pass
finally:
if warnings_module is not None:
sys.modules["warnings"] = warnings_module


if __name__ == "__main__":
unittest.main()
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix ``test.support.warnings_helper.check_warnings()`` failing with a
``KeyError`` when lazy imports have not populated ``sys.modules``.
Loading