Skip to content

gh-151422: Don't link libffi into _ctypes_test.so #151423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freakboy3742 merged 3 commits into from
Jun 15, 2026
Merged

gh-151422: Don't link libffi into _ctypes_test.so #151423

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0011b4e
gh-151422: Don't link libffi into _ctypes_test.so
hoodmane Jun 12, 2026
4fb91c5
Add test skips for ctypes tests that don't work on emscripten
hoodmane Jun 13, 2026
b4eac76
Use skipIf decorator
hoodmane Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Lib/test/test_ctypes/test_as_parameter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
c_short, c_int, c_long, c_longlong,
c_byte, c_wchar, c_float, c_double,
ArgumentError)
from test.support import import_helper, skip_if_sanitizer
from test.support import import_helper, skip_if_sanitizer, skip_emscripten_stack_overflow
_ctypes_test = import_helper.import_module("_ctypes_test")


Expand Down Expand Up @@ -193,6 +193,7 @@ class S8I(Structure):
(9*2, 8*3, 7*4, 6*5, 5*6, 4*7, 3*8, 2*9))

@skip_if_sanitizer('requires deep stack', thread=True)
@skip_emscripten_stack_overflow()
def test_recursive_as_param(self):
class A:
pass
Expand Down
9 changes: 9 additions & 0 deletions Lib/test/test_ctypes/test_structures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,15 @@ class X(Structure):
def _test_issue18060(self, Vector):
# Regression tests for gh-62260

# This test passes a struct of two doubles by value to the atan2(),
# whose actual C signature is atan2(double, double), so it only works on
# platforms where the abi of a function that takes a struct with two
# doubles matches the abi of a function that takes two doubles. The
# wasm32 ABI does not satisfy this condition and the test breaks.
if support.is_wasm32:
self.skipTest(
"wasm ABI is incompatible with test expectations")
Comment thread
hoodmane marked this conversation as resolved.
Resolved

# The call to atan2() should succeed if the
# class fields were correctly cloned in the
# subclasses. Otherwise, it will segfault.
Expand Down
4 changes: 2 additions & 2 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8447,9 +8447,11 @@ PY_STDLIB_MOD([_testmultiphase], [test "$TEST_MODULES" = yes], [test "$ac_cv_fun
PY_STDLIB_MOD([_testsinglephase], [test "$TEST_MODULES" = yes], [test "$ac_cv_func_dlopen" = yes])
PY_STDLIB_MOD([xxsubtype], [test "$TEST_MODULES" = yes])
PY_STDLIB_MOD([_xxtestfuzz], [test "$TEST_MODULES" = yes])
dnl Check have_libffi so _ctypes_test is only built if _ctypes is built.
dnl _ctypes_test doesn't use libffi directly.
PY_STDLIB_MOD([_ctypes_test],
[test "$TEST_MODULES" = yes], [test "$have_libffi" = yes -a "$ac_cv_func_dlopen" = yes],
[$LIBFFI_CFLAGS], [$LIBFFI_LIBS $LIBM])
[], [$LIBM])

dnl Limited API template modules.
dnl Emscripten does not support shared libraries yet.
Expand Down
Loading