Repository navigation
gh-141004: Document unstable executable kind macros in pyframe.h
#143490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1efbe41
first unstable py
Yashp002 4572008
fix 1
Yashp002 54495a2
fix 2(version)
Yashp002 e8097b1
fix 2 pyframe
Yashp002 9c1492f
fix 3 pyframe
Yashp002 a0b1951
fix 4 pyframe
Yashp002 927383b
fix 5 pyframe
Yashp002 e51340a
Merge branch 'main' into doc-pyframe-unstable
Yashp002 3fafd77
fix 6 pyframe
Yashp002 45e9a6d
pyframe fix 7
Yashp002 43e9c9f
pyframe fix 8
Yashp002 efe7161
pyframe fix 9-test
Yashp002 42b775b
Merge branch 'main' into doc-pyframe-unstable
ZeroIntensity e8cd832
Merge branch 'main' of https://github.com/python/cpython into doc-pyf…
ZeroIntensity 2cffd86
Address feedback.
ZeroIntensity a92546c
Fix stray newline change.
ZeroIntensity 561c580
Fix stupid lint.
ZeroIntensity 5c56ebb
Fix missing type.
ZeroIntensity e5e6937
Merge branch 'main' into doc-pyframe-unstable
ZeroIntensity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -250,3 +250,63 @@ Unless using :pep:`523`, you will not need this. | |
| .. versionadded:: 3.12 | ||
|
|
||
|
|
||
| .. c:type:: PyUnstable_ExecutableKinds | ||
|
|
||
| An array of executable kinds (executor types) for frames, used for internal | ||
| debugging and tracing. | ||
|
|
||
| Tools like debuggers and profilers can use this to identify the type of execution | ||
| context associated with a frame (For example: to filter out internal frames). | ||
| The entries are indexed by the following constants: | ||
|
|
||
| .. list-table:: | ||
| :header-rows: 1 | ||
| :widths: auto | ||
|
|
||
| * - Constant | ||
| - Description | ||
| * - .. c:macro:: PyUnstable_EXECUTABLE_KIND_SKIP | ||
| - The frame is internal (For example: inlined) and should be skipped by tools. | ||
| * - .. c:macro:: PyUnstable_EXECUTABLE_KIND_PY_FUNCTION | ||
| - The frame corresponds to a standard Python function. | ||
|
|
||
| Example usage: | ||
|
|
||
| .. code-block:: c | ||
|
|
||
| // Check if a frame should be skipped | ||
| if (kind == PyUnstable_EXECUTABLE_KIND_SKIP) { | ||
| // This is an internal frame (like a Tier 2 optimizer frame) | ||
| // Tools should ignore it. | ||
| continue; | ||
| } | ||
|
|
||
| .. versionadded:: 3.13 | ||
|
|
||
|
|
||
| .. c:macro:: PyUnstable_EXECUTABLE_KIND_PY_FUNCTION | ||
|
|
||
| Index for the "Python function" kind in ``PyUnstable_ExecutableKinds``. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These should be links via |
||
|
|
||
| .. versionadded:: 3.13 | ||
|
|
||
|
|
||
| .. c:macro:: PyUnstable_EXECUTABLE_KIND_BUILTIN_FUNCTION | ||
|
|
||
| Index for the "built-in function" kind in ``PyUnstable_ExecutableKinds``. | ||
|
|
||
| .. versionadded:: 3.13 | ||
|
|
||
|
|
||
| .. c:macro:: PyUnstable_EXECUTABLE_KIND_METHOD_DESCRIPTOR | ||
|
|
||
| Index for the "method descriptor" kind in ``PyUnstable_ExecutableKinds``. | ||
|
|
||
| .. versionadded:: 3.13 | ||
|
|
||
|
|
||
| .. c:macro:: PyUnstable_EXECUTABLE_KINDS | ||
|
|
||
| The number of entries in ``PyUnstable_ExecutableKinds``. | ||
|
|
||
| .. versionadded:: 3.13 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is
kind? How do you get it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@encukou kind here refers to the executable kind field stored in the frame's executor (e.g. _PyFrame_GetExecutableKind(frame))
Do you think it's better to explicitly show _PyFrame_GetExecutableKind (if exposed), or should I just remove the example block to avoid confusion?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, explicitly show your
_PyFrame_GetExecutableKind. We'll also need to make it public (or at least unstable) if we want users to use it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there's no API for getting
kind. The only way to get the right thing is to check the type, but at that point, you don't needPyUnstable_ExecutableKindsanyway (because the whole point of it is that you're not supposed to know the type in advance). This API is quite literally useless. I think we should remove it in 3.16, but for completeness, I want this documented in 3.13+.