Skip to content

bpo-27987: pymalloc: align by 16bytes on 64bit platform #12850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 3 commits into from
May 14, 2019
Merged

bpo-27987: pymalloc: align by 16bytes on 64bit platform #12850

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfdc958
bpo-27987: pymalloc: align by 16bytes on 64bit platform
methane Apr 16, 2019
ed6b7fd
add news entry
methane Apr 16, 2019
b8b714a
Update 2019-04-16-11-52-21.bpo-27987.n2_DcQ.rst
methane Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2019-04-16-11-52-21.bpo-27987.n2_DcQ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
pymalloc returns memory blocks aligned by 16 bytes instead of 8 bytes on 64
bit platforms, as recent compilers assume malloc returns 16 byte aligned
memory block. Patch by Inada Naoki.
Comment thread
methane marked this conversation as resolved.
Resolved
6 changes: 6 additions & 0 deletions Objects/obmalloc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,8 +795,14 @@ static int running_on_valgrind = -1;
*
* You shouldn't change this unless you know what you are doing.
*/

#if SIZEOF_VOID_P > 4
#define ALIGNMENT 16 /* must be 2^N */
#define ALIGNMENT_SHIFT 4
#else
#define ALIGNMENT 8 /* must be 2^N */
#define ALIGNMENT_SHIFT 3
#endif

/* Return the number of bytes in size class I, as a uint. */
#define INDEX2SIZE(I) (((uint)(I) + 1) << ALIGNMENT_SHIFT)
Expand Down