Skip to content

gh-120242: Fix handling of [setUp,tearDown]Class in test_datetime #120243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 2 commits into from
Jun 8, 2024
Merged

gh-120242: Fix handling of [setUp,tearDown]Class in test_datetime #120243

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c6f61e
gh-120242: Fix handling of `[setUp,tearDown]Class` in `test_datetime`
sobolevn Jun 7, 2024
7c81c0c
Address review
sobolevn Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Lib/test/test_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,24 @@ def load_tests(loader, tests, pattern):
test_classes.extend(type(test) for test in suit)
test_classes = sorted(set(test_classes), key=lambda cls: cls.__qualname__)
for cls in test_classes:
orig_setUpClass = getattr(cls, 'setUpClass', None)
orig_tearDownClass = getattr(cls, 'tearDownClass', None)
cls.__name__ += suffix
cls.__qualname__ += suffix
@classmethod
def setUpClass(cls_, module=module):
def setUpClass(cls_, module=module, orig_setUpClass=orig_setUpClass):
cls_._save_sys_modules = sys.modules.copy()
sys.modules[TESTS] = module
sys.modules['datetime'] = module.datetime_module
if hasattr(module, '_pydatetime'):
sys.modules['_pydatetime'] = module._pydatetime
sys.modules['_strptime'] = module._strptime
if orig_setUpClass is not None:
orig_setUpClass()
@classmethod
def tearDownClass(cls_):
def tearDownClass(cls_, orig_tearDownClass=orig_tearDownClass):
if orig_tearDownClass is not None:
orig_tearDownClass()
sys.modules.clear()
sys.modules.update(cls_._save_sys_modules)
cls.setUpClass = setUpClass
Comment thread
sobolevn marked this conversation as resolved.
Resolved
Expand Down