Skip to content

gh-113655: Reduce recursion limit to a safe number for Windows #113668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdboom wants to merge 2 commits into from
Closed

gh-113655: Reduce recursion limit to a safe number for Windows #113668

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d5ab9f
gh-113655: Reduce recursion limit to a safe number for Windows
mdboom Jan 2, 2024
67f60b5
Make sure recursion always maxes out
mdboom Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Lib/test/test_functools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1876,8 +1876,7 @@ def fib(n):

if not support.Py_DEBUG:
with support.infinite_recursion():
fib(1250)

self.assertRaises(RecursionError, fib, 2000)

@gvanrossum gvanrossum Jan 3, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this violates the intention of the test -- it wants to ensure that we can recurse at least a minimum given number of times. Maybe we need both?

@markshannon markshannon Jan 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have tests for maxing out the recursion limit, both for C and Python recursion, so we probably don't need to add any. But there is no harm in having more tests.

@mdboom mdboom Jan 5, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we already have those tests, I wonder why they aren't likewise failing... Do you know which those are?


@py_functools.lru_cache()
def py_cached_func(x, y):
Expand Down