Skip to content

gh-108558: Improve sqlite3 row factory tests #108578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 6 commits into from
Aug 29, 2023
Merged

gh-108558: Improve sqlite3 row factory tests #108578

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94dbb50
Add test_sqlite_row_keys poc
EddInSverige Aug 28, 2023
1057e85
Replace docstrings with regular comments in row tests
EddInSverige Aug 29, 2023
746ef10
Improve test comment
EddInSverige Aug 29, 2023
bdb16be
Merge branch 'python:main' into gh-108558-fix
EddInSverige Aug 29, 2023
ed4953d
Update Lib/test/test_sqlite3/test_factory.py
erlend-aasland Aug 29, 2023
a37159c
Reduce boilerplate code and fixup a docstring
erlend-aasland Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Lib/test/test_sqlite3/test_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,13 @@ def test_sqlite_row_as_sequence(self):
self.assertEqual(list(reversed(row)), list(reversed(as_tuple)))
self.assertIsInstance(row, Sequence)

def test_sqlite_row_keys(self):
""" Checks if the row object can return its keys """
Comment thread
erlend-aasland marked this conversation as resolved.
Resolved
self.con.row_factory = sqlite.Row
row = self.con.execute("select 1 as a, 2 as b").fetchone()

Comment thread
erlend-aasland marked this conversation as resolved.
Resolved
self.assertEqual(row.keys(), ['a', 'b'])

def test_fake_cursor_class(self):
# Issue #24257: Incorrect use of PyObject_IsInstance() caused
# segmentation fault.
Expand Down