Skip to content

GH-78530: add support for generators in asyncio.wait #102761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 3 commits into from
Mar 17, 2023
Merged

GH-78530: add support for generators in asyncio.wait #102761

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17cddcb
add support for generators
kumaraditya303 Dec 8, 2022
1369707
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 16, 2023
635267d
Update Doc/whatsnew/3.12.rst
kumaraditya303 Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Doc/library/asyncio-task.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,10 @@ Waiting Primitives
.. versionchanged:: 3.11
Passing coroutine objects to ``wait()`` directly is forbidden.

.. versionchanged:: 3.12
Added support for generators yielding tasks.


.. function:: as_completed(aws, *, timeout=None)

Run :ref:`awaitable objects <asyncio-awaitables>` in the *aws*
Expand Down
3 changes: 3 additions & 0 deletions Doc/whatsnew/3.12.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,9 @@ asyncio
:mod:`asyncio` does not support legacy generator-based coroutines.
(Contributed by Kumar Aditya in :gh:`102748`.)

* :func:`asyncio.wait` now accepts generators yielding tasks.
(Contributed by Kumar Aditya in :gh:`78530`)
Comment thread
kumaraditya303 marked this conversation as resolved.
Resolved

inspect
-------

Expand Down
16 changes: 16 additions & 0 deletions Lib/test/test_asyncio/test_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1373,6 +1373,22 @@ async def foo():
self.assertEqual(res, 42)
self.assertAlmostEqual(0.15, loop.time())


def test_wait_generator(self):
async def func(a):
return a

loop = self.new_test_loop()

async def main():
tasks = (self.new_task(loop, func(i)) for i in range(10))
done, pending = await asyncio.wait(tasks, return_when=asyncio.ALL_COMPLETED)
self.assertEqual(len(done), 10)
self.assertEqual(len(pending), 0)

loop.run_until_complete(main())


def test_as_completed(self):

def gen():
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2023-03-16-16-43-04.gh-issue-78530.Lr8eq_.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
:func:`asyncio.wait` now accepts generators yielding tasks. Patch by Kumar Aditya.