You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee=Noneclosed_at=<Date2022-03-20.14:39:53.501>created_at=<Date2022-03-14.20:38:01.268>labels= ['type-feature', 'tests', '3.11']
title='Update tests from asyncore to asyncio'updated_at=<Date2022-03-20.14:39:53.500>user='https://github.com/arhadthedev'
PEP-594 – Removing dead batteries from the standard library [1] removes asyncore and asynchat in 3.12 with the following note:
The asyncore module is also used in stdlib tests. The tests for ftplib, logging, smptd, smtplib, and ssl are partly based on asyncore. These tests must be updated to use asyncio or threading.
(Note: the tests for os module are not mentioned and smtpd will be removed in 3.12 along with its tests anyway)
I'm performing the update now to avoid keeping asynchat and asyncore as private subpackages of test package.
Activity
arhadthedev commentedon Mar 14, 2022
PEP-594 – Removing dead batteries from the standard library [1] removes asyncore and asynchat in 3.12 with the following note:
(Note: the tests for
osmodule are not mentioned and smtpd will be removed in 3.12 along with its tests anyway)I'm performing the update now to avoid keeping asynchat and asyncore as private subpackages of
testpackage.[1] https://peps.python.org/pep-0594/
arhadthedev commentedon Mar 18, 2022
The PR is ready for a review; I sorted out all bugs.
asvetlov commentedon Mar 20, 2022
New changeset 3ae975f by Oleg Iarygin in branch 'main':
bpo-47015: Update test_os from asyncore to asyncio (GH-31876)
3ae975f