Skip to content

Update tests from asyncore to asyncio #91171

Closed

Description

@arhadthedev
BPO 47015
Nosy @josiahcarlson, @giampaolo, @asvetlov, @1st1, @arhadthedev
PRs
  • bpo-47015: Update test_os from asyncore to asyncio #31876
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2022-03-20.14:39:53.501>
    created_at = <Date 2022-03-14.20:38:01.268>
    labels = ['type-feature', 'tests', '3.11']
    title = 'Update tests from asyncore to asyncio'
    updated_at = <Date 2022-03-20.14:39:53.500>
    user = 'https://github.com/arhadthedev'

    bugs.python.org fields:

    activity = <Date 2022-03-20.14:39:53.500>
    actor = 'asvetlov'
    assignee = 'none'
    closed = True
    closed_date = <Date 2022-03-20.14:39:53.501>
    closer = 'asvetlov'
    components = ['Tests']
    creation = <Date 2022-03-14.20:38:01.268>
    creator = 'arhadthedev'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 47015
    keywords = ['patch']
    message_count = 3.0
    messages = ['415185', '415518', '415608']
    nosy_count = 6.0
    nosy_names = ['josiahcarlson', 'giampaolo.rodola', 'stutzbach', 'asvetlov', 'yselivanov', 'arhadthedev']
    pr_nums = ['31876']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue47015'
    versions = ['Python 3.11']

    Activity

    1. arhadthedev commented on Mar 14, 2022

      @arhadthedev
      MemberAuthor

      PEP-594 – Removing dead batteries from the standard library [1] removes asyncore and asynchat in 3.12 with the following note:

      The asyncore module is also used in stdlib tests. The tests for ftplib, logging, smptd, smtplib, and ssl are partly based on asyncore. These tests must be updated to use asyncio or threading.

      (Note: the tests for os module are not mentioned and smtpd will be removed in 3.12 along with its tests anyway)

      I'm performing the update now to avoid keeping asynchat and asyncore as private subpackages of test package.

      [1] https://peps.python.org/pep-0594/

    2. added
      3.11only security fixes
      testsTests in the Lib/test dir
      type-featureA feature request or enhancement
      on Mar 14, 2022
    3. arhadthedev commented on Mar 18, 2022

      @arhadthedev
      MemberAuthor

      The PR is ready for a review; I sorted out all bugs.

    4. asvetlov commented on Mar 20, 2022

      @asvetlov
      Contributor

      New changeset 3ae975f by Oleg Iarygin in branch 'main':
      bpo-47015: Update test_os from asyncore to asyncio (GH-31876)
      3ae975f

    5. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.11only security fixestestsTests in the Lib/test dirtype-featureA feature request or enhancement

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions