Skip to content

test_peg_generator is extremely slow #90734

Description

@gpshead
BPO 46576
Nosy @gpshead, @jkloth, @miss-islington, @tirkarthi
PRs
  • bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. #31015
  • [3.10] bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator #31089
  • [3.9] [3.10] bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (GH-31015) (GH-31089) #31093
  • bpo-46576: Speed up test_peg_generator by using a static library for shared sources #32338
  • [3.10] bpo-46576: Speed up test_peg_generator by using a static libra… #32382
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gpshead'
    closed_at = <Date 2022-02-03.08:25:22.004>
    created_at = <Date 2022-01-29.20:31:42.298>
    labels = ['tests', '3.9', '3.10', '3.11']
    title = 'test_peg_generator is extremely slow'
    updated_at = <Date 2022-04-06.22:22:07.128>
    user = 'https://github.com/gpshead'

    bugs.python.org fields:

    activity = <Date 2022-04-06.22:22:07.128>
    actor = 'jkloth'
    assignee = 'gregory.p.smith'
    closed = True
    closed_date = <Date 2022-02-03.08:25:22.004>
    closer = 'gregory.p.smith'
    components = ['Tests']
    creation = <Date 2022-01-29.20:31:42.298>
    creator = 'gregory.p.smith'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 46576
    keywords = ['patch']
    message_count = 8.0
    messages = ['412104', '412125', '412396', '412416', '412418', '412424', '416797', '416902']
    nosy_count = 4.0
    nosy_names = ['gregory.p.smith', 'jkloth', 'miss-islington', 'xtreak']
    pr_nums = ['31015', '31089', '31093', '32338', '32382']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'commit review'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue46576'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    Activity

    1. gpshead commented on Jan 29, 2022

      @gpshead
      MemberAuthor

      test_peg_generator is an extremely slow test. This bug tracks any changes to reduce its runtime and test latency.

    2. added
      3.11only security fixes
      testsTests in the Lib/test dir
      on Jan 29, 2022
    3. tirkarthi commented on Jan 30, 2022

      @tirkarthi
      Member

      See also bpo-46524 for a similar discussion.

    4. gpshead commented on Feb 2, 2022

      @gpshead
      MemberAuthor

      New changeset 164a017 by Gregory P. Smith in branch 'main':
      bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (bpo-31015)
      164a017

    5. gpshead commented on Feb 3, 2022

      @gpshead
      MemberAuthor

      New changeset f5ebec4 by Gregory P. Smith in branch '3.10':
      [3.10] bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (GH-31015) (GH-31089)
      f5ebec4

    6. miss-islington commented on Feb 3, 2022

      @miss-islington
      Contributor

      New changeset e825860 by Miss Islington (bot) in branch '3.9':
      [3.9] [3.10] bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (GH-31015) (GH-31089) (GH-31093)
      e825860

    7. gpshead commented on Feb 3, 2022

      @gpshead
      MemberAuthor

      for my purposes those PRs make it reasonable, even though it remains one of our slowest tests. we can reopen/reuse this issue for any further test_peg_generator performance improvements as needed.

    8. self-assigned this
      on Feb 3, 2022
    9. self-assigned this
      on Feb 3, 2022
    10. jkloth commented on Apr 5, 2022

      @jkloth
      Contributor

      My PR-32338 further reduces the runtime of the test another ~25%.

      On my machine, before 85s, after 65s.

    11. gpshead commented on Apr 6, 2022

      @gpshead
      MemberAuthor

      New changeset 612e422 by Jeremy Kloth in branch 'main':
      bpo-46576: Speed up test_peg_generator by using a static library for shared sources (GH-32338)
      612e422

    12. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    Labels

    3.10 (EOL)end of life3.11only security fixes3.9 (EOL)end of lifetestsTests in the Lib/test dir

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions