Skip to content

Mark /configure file as generated in .gitattributes #90196

Closed
Closed
Mark /configure file as generated in .gitattributes#90196
Labels
3.11only security fixesbuildThe build process and cross-buildtype-featureA feature request or enhancement

Description

@arhadthedev
arhadthedev
opened on Dec 10, 2021
BPO 46038
Nosy @arhadthedev
PRs
  • bpo-46038: Mark /configure file as generated in .gitattributes #30031
  • Update generated files list and add diff=generated attribute #30745
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-01-21.13:47:24.929>
created_at = <Date 2021-12-10.16:19:15.195>
labels = ['type-feature', 'build', '3.11']
title = 'Mark /configure file as generated in .gitattributes'
updated_at = <Date 2022-01-21.13:47:24.929>
user = 'https://github.com/arhadthedev'

    bugs.python.org fields:

    activity = <Date 2022-01-21.13:47:24.929>
actor = 'arhadthedev'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-21.13:47:24.929>
closer = 'arhadthedev'
components = ['Build']
creation = <Date 2021-12-10.16:19:15.195>
creator = 'arhadthedev'
dependencies = []
files = []
hgrepos = []
issue_num = 46038
keywords = ['patch']
message_count = 2.0
messages = ['408218', '411128']
nosy_count = 1.0
nosy_names = ['arhadthedev']
pr_nums = ['30031', '30745']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue46038'
versions = ['Python 3.11']

    Activity

    1. arhadthedev commented on Dec 10, 2021

      @arhadthedev
      arhadthedev
      on Dec 10, 2021
      MemberAuthor

      configure is regenerated from configure.ac using a custom container with appropriate version of tools (quay.io/tiran/cpython_autoconf by Christian Heimes). As a result, configure falls into the same category as files generated by Argument Clinic, Freeze and Parser/asdl_c.py. Due to size and churn of these artifacts, they are marked in .gitattributes as generated so GitHub Pull Request Diff Viewer collapses them into a short notification. The pull request associated with this issue does the same for configure.

      Actually, configure diff is so large that sometimes it crosses a threshold and GitHub collapses it by force with "Large diffs are not rendered by default" or even "xxx additions, yyy deletions not shown because the diff is too large. Please use a local Git client to view these changes". See #73942 as an extreme example (15,430 insertions and deletions) and <https://github.com/python/cpython/commits/main/configure\> for an average.

    2. arhadthedev
      added
      3.11only security fixes
      buildThe build process and cross-build
      type-featureA feature request or enhancement
      on Dec 10, 2021

    3. arhadthedev commented on Jan 21, 2022

      @arhadthedev
      arhadthedev
      on Jan 21, 2022
      MemberAuthor

      Superseded by <https://github.com/python/core-workflow/issues/425\>. The PR itself is included as a part of PR30745.

    4. arhadthedev
      closed this as completedon Jan 21, 2022
    5. arhadthedev
      closed this as completedon Jan 21, 2022
    6. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.11only security fixesbuildThe build process and cross-buildtype-featureA feature request or enhancement

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions