Repository navigation
[doc] "history and license" link has wrong target #89892
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2022-01-12.10:19:18.467>
created_at = <Date 2021-11-05.16:06:13.804>
labels = ['3.11', 'type-bug', '3.9', '3.10', 'docs']
title = '[doc] "history and license" link has wrong target'
updated_at = <Date 2022-01-13.15:42:25.845>
user = 'https://github.com/programmerjake'bugs.python.org fields:
activity = <Date 2022-01-13.15:42:25.845>
actor = 'mdk'
assignee = 'docs@python'
closed = True
closed_date = <Date 2022-01-12.10:19:18.467>
closer = 'mdk'
components = ['Documentation']
creation = <Date 2021-11-05.16:06:13.804>
creator = 'programmerjake'
dependencies = []
files = []
hgrepos = []
issue_num = 45729
keywords = ['patch']
message_count = 8.0
messages = ['405807', '405818', '405820', '405822', '410284', '410390', '410411', '410494']
nosy_count = 5.0
nosy_names = ['eric.araujo', 'docs@python', 'mdk', 'miss-islington', 'programmerjake']
pr_nums = ['30527', '30540', '30541']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue45729'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
Activity
programmerjake commentedon Nov 5, 2021
https://docs.python.org/3.10/library/csv.html
at the bottom the "history and license" link just links back to csv.html, rather than the correct target.
merwok commentedon Nov 5, 2021
It happens on all pages for all versions, because the link is empty.
3.8 doesn’t have that line so doesn’t show the bug. I am trying to find where that is defined. Strangely, I don’t find results looking for
please donatewhich is the line below…[-]"history and license" link has wrong target[/-][+][doc] "history and license" link has wrong target[/+][-]"history and license" link has wrong target[/-][+][doc] "history and license" link has wrong target[/+]merwok commentedon Nov 5, 2021
Tracked to python/python-docs-theme#89
AlexWaygood: can I ask why add pseudo-tags to the title field when we do have structured data (components set to doc) on this tracker? Is it a new practice?
AlexWaygood commentedon Nov 5, 2021
@Éric: I personally found it difficult to immediately understand what the issue was about when reading only the title on the BPO homepage, and thought the change in title would help clarify, having seen other documentation issues marked similarly on the tracker.
JulienPalard commentedon Jan 11, 2022
This should be fixed in python-docs-theme==2022.1.
I'll close the issue when I actually see the fix applied on docs.python.org.
JulienPalard commentedon Jan 12, 2022
I checked on docs.python.org and it's fixed.
merwok commentedon Jan 12, 2022
dev docs direct to
/license.htmlwhich redirects to/3/license.html3.9 docs have the same; wouldn’t it be better to have
/3.9/license.html?JulienPalard commentedon Jan 13, 2022
All docs are redirecting to
/license.html, this allow it to work also out of docs.python.org.It's maybe a slight better yes (the page should be the same so I don't know if it make real difference), but doing so means a bit of complexity, which I don't think is worth it.
I tried to keep it simple for this fix (the previous state was "links to the current page" which was worse).