Skip to content

Specialize INPLACE_ADD #89671

Closed
Closed
Specialize INPLACE_ADD#89671

Description

@sweeneyde
sweeneyde
opened on Oct 18, 2021
BPO 45508
Nosy @sweeneyde
PRs
  • bpo-45508: Specialize INPLACE_ADD #29024
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-12-29.07:19:05.337>
created_at = <Date 2021-10-18.09:49:41.994>
labels = []
title = 'Specialize INPLACE_ADD'
updated_at = <Date 2021-12-29.07:19:05.337>
user = 'https://github.com/sweeneyde'

    bugs.python.org fields:

    activity = <Date 2021-12-29.07:19:05.337>
actor = 'Dennis Sweeney'
assignee = 'none'
closed = True
closed_date = <Date 2021-12-29.07:19:05.337>
closer = 'Dennis Sweeney'
components = []
creation = <Date 2021-10-18.09:49:41.994>
creator = 'Dennis Sweeney'
dependencies = []
files = []
hgrepos = []
issue_num = 45508
keywords = ['patch']
message_count = 1.0
messages = ['404171']
nosy_count = 1.0
nosy_names = ['Dennis Sweeney']
pr_nums = ['29024']
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue45508'
versions = []

    Activity

    1. sweeneyde commented on Oct 18, 2021

      @sweeneyde
      sweeneyde
      on Oct 18, 2021
      MemberAuthor

      I ran on WSL with PGO and got "1.00x faster":
      https://gist.github.com/sweeneyde/41a76356e875e2a98d16ce5410ab41c0

      My benchmarking doesn't seem particularly reliable, so someone else should probably verify.

      Great specialization stats, except for telco, which uses decimal += decimal.

      bm_fannkuch:
      inplace_add.specialization_success : 23
      inplace_add.specialization_failure : 3
      inplace_add.hit : 7968285
      inplace_add.deferred : 198
      inplace_add.miss : 39
      inplace_add.deopt : 3
      inplace_add.unquickened : 168

      bm_nbody:
      inplace_add.specialization_success : 27
      inplace_add.specialization_failure : 3
      inplace_add.hit : 3600615
      inplace_add.deferred : 198
      inplace_add.miss : 39
      inplace_add.deopt : 3
      inplace_add.unquickened : 178

      bm_spectral_norm:
      inplace_add.specialization_success : 24
      inplace_add.specialization_failure : 5
      inplace_add.hit : 2684690
      inplace_add.deferred : 326
      inplace_add.miss : 20843
      inplace_add.deopt : 3
      inplace_add.unquickened : 171

      bm_telco:
      inplace_add.specialization_success : 21
      inplace_add.specialization_failure : 18537
      inplace_add.hit : 597
      inplace_add.deferred : 1186282
      inplace_add.miss : 39
      inplace_add.deopt : 3
      inplace_add.unquickened : 187

    2. sweeneyde
      closed this as completedon Dec 29, 2021
    3. sweeneyde
      closed this as completedon Dec 29, 2021
    4. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      No labels
      No labels

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions