Repository navigation
Revert _decimal C API changes #87588
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2021-03-21.16:32:55.181>
created_at = <Date 2021-03-06.15:18:26.422>
labels = ['extension-modules', 'type-bug', '3.10']
title = 'Revert _decimal C API changes'
updated_at = <Date 2021-03-21.16:32:55.181>
user = 'https://github.com/pitrou'bugs.python.org fields:
activity = <Date 2021-03-21.16:32:55.181>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2021-03-21.16:32:55.181>
closer = 'pitrou'
components = ['Extension Modules']
creation = <Date 2021-03-06.15:18:26.422>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 43422
keywords = ['patch']
message_count = 10.0
messages = ['388205', '388208', '388231', '388245', '388278', '388565', '388681', '388683', '388684', '389247']
nosy_count = 9.0
nosy_names = ['rhettinger', 'terry.reedy', 'facundobatista', 'mark.dickinson', 'pitrou', 'vstinner', 'serhiy.storchaka', 'miss-islington', 'shihai1991']
pr_nums = ['24792', '24960']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue43422'
versions = ['Python 3.10']
Activity
pitrou commentedon Mar 6, 2021
Stefan Krah (who doesn't have access rights here, and is the author of the C _decimal module) asked me to transmit me this request:
"""
The capsule API does not meet my testing standards, since I've focused
on the upstream mpdecimal in the last couple of months.
Additionally, I'd like to refine the API, perhaps together with the
Arrow community.
"""
The relevant diff is here:
master...skrah:revert_decimal_capsule_api
I can turn it into a PR but first I'd like to gather reactions here.
rhettinger commentedon Mar 6, 2021
+1 fron me.
mdickinson commentedon Mar 7, 2021
+1 for reverting these before 3.10. See also @mattip's comments on bpo-41324, and bpo-43060.
shihai1991 commentedon Mar 7, 2021
+1 from me. 3.10.0 final haven't been released, so no one will be affected.
vstinner commentedon Mar 8, 2021
I have a concern about the current _decimal C API: bpo-43060. I'm fine with removing it in Python 3.10, and add it back fixed in Python 3.11 or later.
Go ahead.
terryjreedy commentedon Mar 12, 2021
skrah is still a bpo user with an CLA-signed account linked to his github account. So he can post here and, I believe, open a PR as a contributor. But if, under the current circumstances, he feels more comfortable using Antoine as a go between, then I thank Antoine for doing so.
pitrou commentedon Mar 14, 2021
Terry, the list of roles in https://bugs.python.org/user11089 is empty, which I take it to mean that Stefan doesn't have any access rights on this issue tracker (except to read issues). Other users all seem to have the "User" role.
terryjreedy commentedon Mar 14, 2021
OK. I see no structural difference between his page and yours, https://bugs.python.org/user2040. No 'Roles' field, no 'User' entry, on either page, nor on mine. So you must be an admin who sees extra info. In any case, the last part of my comment stands.
pitrou commentedon Mar 14, 2021
FWIW, I have the roles "User,Developer,Coordinator" according to my user page.
You (Terry) have the roles "User,Developer".
Perhaps the "Coordinator" role explains I see things you don't see (it's a better explanation than believing I am a psychic :-D).
miss-islington commentedon Mar 21, 2021
New changeset cdddc2b by Antoine Pitrou in branch 'master':
bpo-43422: Revert _decimal C API addition (GH-24960)
cdddc2b