Repository navigation
2to3 reports some files as both not changing and having been modified #85282
Description
| BPO | 41110 |
|---|---|
| Nosy | @benjaminp, @AWhetter |
| PRs | |
| Superseder |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2021-10-20.22:51:55.292>
created_at = <Date 2020-06-25.04:46:55.584>
labels = ['3.8', 'type-bug', 'expert-2to3', '3.9', '3.10']
title = '2to3 reports some files as both not changing and having been modified'
updated_at = <Date 2021-10-20.22:51:55.291>
user = 'https://github.com/AWhetter'bugs.python.org fields:
activity = <Date 2021-10-20.22:51:55.291>
actor = 'iritkatriel'
assignee = 'none'
closed = True
closed_date = <Date 2021-10-20.22:51:55.292>
closer = 'iritkatriel'
components = ['2to3 (2.x to 3.x conversion tool)']
creation = <Date 2020-06-25.04:46:55.584>
creator = 'AWhetter'
dependencies = []
files = []
hgrepos = []
issue_num = 41110
keywords = ['patch']
message_count = 1.0
messages = ['372299']
nosy_count = 2.0
nosy_names = ['benjamin.peterson', 'AWhetter']
pr_nums = ['21296']
priority = 'normal'
resolution = 'wont fix'
stage = 'resolved'
status = 'closed'
superseder = '45544'
type = 'behavior'
url = 'https://bugs.python.org/issue41110'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
Activity
AWhetter commentedon Jun 25, 2020
Many of the fixers cause the tool to report a file as both unchanged and modified.
For example when checking a file with the following contents:
using the following command:
python -m lib2to3 -f unicode unicode_test.pyThe following is output:
When a fixer returns a node, even if it is the original node without changes, it is considered as a change to the code (
cpython/Lib/lib2to3/refactor.py
Lines 446 to 447 in cf18c9e
The fix appears to be that fixers need to be aware of when they have not made a change and should
Nonewhen that is the case.