Repository navigation
--with-valgrind broken #85058
Description
| BPO | 40881 |
|---|---|
| Nosy | @vstinner, @skrah |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2020-06-07.23:40:14.920>
created_at = <Date 2020-06-05.22:38:42.660>
labels = ['build', '3.10']
title = '--with-valgrind broken'
updated_at = <Date 2020-06-07.23:40:14.908>
user = 'https://github.com/skrah'bugs.python.org fields:
activity = <Date 2020-06-07.23:40:14.908>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-06-07.23:40:14.920>
closer = 'vstinner'
components = ['Build']
creation = <Date 2020-06-05.22:38:42.660>
creator = 'skrah'
dependencies = []
files = []
hgrepos = []
issue_num = 40881
keywords = ['patch']
message_count = 4.0
messages = ['370793', '370927', '370930', '370931']
nosy_count = 2.0
nosy_names = ['vstinner', 'skrah']
pr_nums = ['20699']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue40881'
versions = ['Python 3.10']
Activity
skrah commentedon Jun 5, 2020
./configure --with-valgrind:
Objects/unicodeobject.c: In function ‘unicode_release_interned’:
Objects/unicodeobject.c:15672:26: error: lvalue required as left operand of assignment
Py_REFCNT(s) += 1;
^
Objects/unicodeobject.c:15678:26: error: lvalue required as left operand of assignment
Py_REFCNT(s) += 2;
Well, Py_REFCNT(s) is no longer an lvalue. :-)
vstinner commentedon Jun 7, 2020
Regression introduced by my commit fe2978b: bpo-39573. I wrote a PR 20699 to fix unicode_release_interned().
vstinner commentedon Jun 7, 2020
New changeset c96a61e by Victor Stinner in branch 'master':
bpo-40881: Fix unicode_release_interned() (GH-20699)
c96a61e
vstinner commentedon Jun 7, 2020
Fixed. Thanks for the bug report Stefan!