Skip to content

pythoncore.vcxproj fails to load due to duplicated "..\Include\pyhash.h" #84581

Closed

Description

@ammaraskar
BPO 40401
Nosy @pfmoore, @tjguk, @zware, @zooba, @ammaraskar
PRs
  • bpo-40401: Remove duplicate pyhash.h include from pythoncore.vcxproj #19725
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-04-27.02:09:02.784>
    created_at = <Date 2020-04-26.23:53:07.153>
    labels = ['build', '3.9', 'OS-windows']
    title = 'pythoncore.vcxproj fails to load due to duplicated "..\\Include\\pyhash.h"'
    updated_at = <Date 2020-04-27.02:09:02.783>
    user = 'https://github.com/ammaraskar'

    bugs.python.org fields:

    activity = <Date 2020-04-27.02:09:02.783>
    actor = 'zach.ware'
    assignee = 'none'
    closed = True
    closed_date = <Date 2020-04-27.02:09:02.784>
    closer = 'zach.ware'
    components = ['Windows']
    creation = <Date 2020-04-26.23:53:07.153>
    creator = 'ammar2'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 40401
    keywords = ['patch']
    message_count = 3.0
    messages = ['367334', '367352', '367353']
    nosy_count = 5.0
    nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'ammar2']
    pr_nums = ['19725']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue40401'
    versions = ['Python 3.9']

    Activity

    1. ammaraskar commented on Apr 26, 2020

      @ammaraskar
      MemberAuthor

      The pythoncore project currently fails to load in Visual Studio with:

      cpython\PCbuild\pythoncore.vcxproj : error  : Cannot load project with duplicated project items: ..\Include\pyhash.h is included as 'ClInclude' and as 'ClInclude' item types. 
      

      Looks like c5fc156#diff-fc48a1700be0140b57a172ea101297de accidentally introduced a duplicate for "..\Include\pyhash.h"

    2. zware commented on Apr 27, 2020

      @zware
      Member

      New changeset a494caa by Ammar Askar in branch 'master':
      bpo-40401: Remove duplicate pyhash.h include from pythoncore.vcxproj (GH-19725)
      a494caa

    3. zware commented on Apr 27, 2020

      @zware
      Member

      Thanks for the patch :)

    4. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions