Repository navigation
Use new _at_fork_reinit() lock method in multiprocessing #84402
Description
| BPO | 40221 |
|---|---|
| Nosy | @vstinner, @corona10, @shihai1991 |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2020-04-14.16:38:40.314>
created_at = <Date 2020-04-07.23:03:53.125>
labels = ['type-feature', 'library', '3.9']
title = 'Use new _at_fork_reinit() lock method in multiprocessing'
updated_at = <Date 2020-04-14.16:38:40.313>
user = 'https://github.com/vstinner'bugs.python.org fields:
activity = <Date 2020-04-14.16:38:40.313>
actor = 'corona10'
assignee = 'none'
closed = True
closed_date = <Date 2020-04-14.16:38:40.314>
closer = 'corona10'
components = ['Library (Lib)']
creation = <Date 2020-04-07.23:03:53.125>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 40221
keywords = ['patch']
message_count = 6.0
messages = ['365957', '366205', '366207', '366386', '366399', '366400']
nosy_count = 3.0
nosy_names = ['vstinner', 'corona10', 'shihai1991']
pr_nums = ['19477', '19511']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue40221'
versions = ['Python 3.9']
Activity
vstinner commentedon Apr 7, 2020
Currently, _ResourceSharer._after_fork() of multiprocessing.resource_sharer creates new locks and leak old locks on purpose. This method can benefit of the newly added _at_fork_reinit() method added by bpo-40089.
Queue._after_fork() could also call self._notempty._at_fork_reinit().
Also: ForkAwareThreadLock could reinitializes its lock.
corona10 commentedon Apr 11, 2020
I am going to take a look
corona10 commentedon Apr 11, 2020
we should find all usages from Lib/multiprocessing/*.py
corona10 commentedon Apr 14, 2020
New changeset e194530 by Dong-hee Na in branch 'master':
bpo-40221: Update multiprocessing to use _at_fork_reinit (GH-19477)
e194530
corona10 commentedon Apr 14, 2020
New changeset a5900ec by Dong-hee Na in branch 'master':
bpo-40221: Update multiprocessing to use _at_fork_reinit (GH-19511)
a5900ec
corona10 commentedon Apr 14, 2020
Looks like we update all the methods which are related to _after_fork
under Lib/multiprocessing.
I am now closing this issue.
Thanks for the suggestion, Victor :)