Skip to content

Use the codecov GH Action #83958

Closed as not planned
Closed as not planned
Use the codecov GH Action#83958
Labels
testsTests in the Lib/test dir

Description

@brettcannon
brettcannon
opened on Feb 27, 2020
BPO 39777
Nosy @brettcannon, @zooba, @ammaraskar

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-02-27.21:09:04.987>
labels = []
title = 'Use the codecov GH Action'
updated_at = <Date 2020-02-27.21:26:43.895>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2020-02-27.21:26:43.895>
actor = 'ammar2'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2020-02-27.21:09:04.987>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 39777
keywords = []
message_count = 3.0
messages = ['362839', '362843', '362845']
nosy_count = 3.0
nosy_names = ['brett.cannon', 'steve.dower', 'ammar2']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue39777'
versions = []

Activity

  1. brettcannon commented on Feb 27, 2020

    @brettcannon
    brettcannon
    on Feb 27, 2020
    MemberAuthor

    Codecov provides a GH Action for uploading coverage reports which we might as well use instead of their bash uploader: https://github.com/marketplace/actions/codecov.

  2. ammaraskar commented on Feb 27, 2020

    @ammaraskar
    ammaraskar
    on Feb 27, 2020
    Member

    This has the disadvantage that it won't work for PRs because Github doesn't make secrets like ${{ secrets.CODECOV_TOKEN }} available in PRs.

    See: codecov/codecov-action#29

  3. ammaraskar commented on Feb 27, 2020

    @ammaraskar
    ammaraskar
    on Feb 27, 2020
    Member

    On a second look, we currently do this anyway:

    cpython/.github/workflows/coverage.yml

    Lines 66 to 70 in 374d998

    run: |
    source ./.venv/bin/activate
    bash <(curl -s https://codecov.io/bash)
    env:
    CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

    and don't run coverage for PRs so it shouldn't matter.

  4. ezio-melotti
    transferred this issue fromon Apr 10, 2022
  5. iritkatriel
    added
    testsTests in the Lib/test dir
    on Nov 27, 2023

  6. hugovk commented on Feb 24, 2024

    @hugovk
    hugovk
    on Feb 24, 2024
    Member

    No longer relevant, we removed coverage from the CI in #25679.

  7. hugovk
    closed this as not plannedon Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dir

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions