Skip to content

test_largefile: TestSocketSendfile.test_it() uses too much disk space #83669

Closed
Closed
test_largefile: TestSocketSendfile.test_it() uses too much disk space#83669
Labels
3.9 (EOL)end of lifetestsTests in the Lib/test dir

Description

@vstinner
vstinner
opened on Jan 29, 2020
BPO 39488
Nosy @vstinner, @giampaolo
PRs
  • bpo-39488: skip bigfile test if not enough disk space #18261
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-02-05.17:23:24.055>
created_at = <Date 2020-01-29.17:14:09.634>
labels = ['tests', '3.9']
title = 'test_largefile: TestSocketSendfile.test_it() uses too much disk space'
updated_at = <Date 2020-02-05.17:23:24.054>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2020-02-05.17:23:24.054>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-02-05.17:23:24.055>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2020-01-29.17:14:09.634>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 39488
keywords = ['patch', 'buildbot']
message_count = 3.0
messages = ['360976', '361440', '361441']
nosy_count = 2.0
nosy_names = ['vstinner', 'giampaolo.rodola']
pr_nums = ['18261']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue39488'
versions = ['Python 3.9']

    Activity

    1. vstinner commented on Jan 29, 2020

      @vstinner
      vstinner
      on Jan 29, 2020
      MemberAuthor

      TestSocketSendfile.test_it() failed with "OSError: [Errno 28] No space left on device" on PPC64LE Fedora 3.x buildbot.

      It also caused troubles on "AMD64 Fedora Rawhide Clang 3.x" worker.

      If I recall correctly, it writes like 8 GB of real data, not just empty files made of holes.

      I suggest to either remove the test or to use way less disk space.

      https://buildbot.python.org/all/#builders/11/builds/259

      Traceback (most recent call last):
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/test/test_largefile.py", line 161, in test_it
    shutil.copyfile(TESTFN, TESTFN2)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/shutil.py", line 270, in copyfile
    _fastcopy_sendfile(fsrc, fdst)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/shutil.py", line 163, in _fastcopy_sendfile
    raise err from None
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/shutil.py", line 149, in _fastcopy_sendfile
    sent = os.sendfile(outfd, infd, offset, blocksize)
OSError: [Errno 28] No space left on device: '@test_38097_tmp' -> '@test_38097_tmp2'
    2. vstinner
      added
      3.9 (EOL)end of life
      testsTests in the Lib/test dir
      on Jan 29, 2020

    3. vstinner commented on Feb 5, 2020

      @vstinner
      vstinner
      on Feb 5, 2020
      MemberAuthor

      New changeset b39fb8e by Giampaolo Rodola in branch 'master':
      bpo-39488: Skip test_largefile tests if not enough disk space (GH-18261)
      b39fb8e

    4. vstinner commented on Feb 5, 2020

      @vstinner
      vstinner
      on Feb 5, 2020
      MemberAuthor

      Giampaolo Rodola modified the tests to skip them if there is not enough disk space. Let's see if it's enough to fix these buildbots. Since the issue was random, I close the issue and just hope that it's now fixed :-)

    5. vstinner
      closed this as completedon Feb 5, 2020
    6. vstinner
      closed this as completedon Feb 5, 2020
    7. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.9 (EOL)end of lifetestsTests in the Lib/test dir

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions