test_threading leaked [1, 1, 1] references: test_threads_join #82357

Activity

1. vstinner commented on Sep 15, 2019

   

   vstinner

   on Sep 15, 2019

   MemberAuthor

   More actions

   vstinner@apu$ ./python -m test -R 3:3 test_threading -m test.test_threading.SubinterpThreadingTests.test_threads_join
   Run tests sequentially
   0:00:00 load avg: 1.11 [1/1] test_threading
   beginning 6 repetitions
   123456
   ......
   test_threading leaked [1, 1, 1] references, sum=3
   test_threading failed

   == Tests result: FAILURE ==

   1 test failed:
   test_threading

   Total duration: 639 ms
   Tests result: FAILURE
2. vstinner

   added

   3.9 (EOL)end of lifeend of life

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   on Sep 15, 2019
3. vstinner commented on Sep 15, 2019

   

   vstinner

   on Sep 15, 2019

   MemberAuthor

   More actions

   The regression seems to be introduced by:

   commit 04f0bbf (HEAD, refs/bisect/bad)
   Author: Dino Viehland <dinoviehland@fb.com>
   Date: Fri Sep 13 11:12:27 2019 +0100

   bpo-38075: Port _randommodule.c to PEP-384 (GH-15798)
   
   - Migrate `Random_Type` to `PyType_FromSpec`
   - To simulate an old use of `PyLong_Type.tp_as_number->nb_absolute`, I added
     code to the module init function to stash `int.__abs__` for later
     use. Ideally we'd use `PyType_GetSlot()` instead, but it doesn't currently
     work for static types in CPython, and implementing it just for this case
     doesn't seem worth it.
   - Do exact check for long and dispatch to PyNumber_Absolute, use vector call when not exact.
   
4. DinoV

   self-assigned this

   on Sep 15, 2019
5. DinoV

   closed this as completedon Sep 15, 2019
6. vstinner commented on Sep 16, 2019

   

   vstinner

   on Sep 16, 2019

   MemberAuthor

   More actions

   commit 09dc2c6
   Author: Dino Viehland <dinoviehland@gmail.com>
   Date: Sun Sep 15 15:51:44 2019 +0100

   Fix missing dec ref (bpo-16158)
   

   diff --git a/Modules/_randommodule.c b/Modules/_randommodule.c
   index 8b0a0244bf..1ea2bf28ab 100644
   --- a/Modules/_randommodule.c
   +++ b/Modules/_randommodule.c
   @@ -572,6 +572,7 @@ static int
    _random_clear(PyObject *module)
    {
        Py_CLEAR(_randomstate(module)->Random_Type);
   +    Py_CLEAR(_randomstate(module)->Long___abs__);
        return 0;
    }
7. ezio-melotti

   transferred this issue fromon Apr 10, 2022