Repository navigation
Make select module PEP-384 compatible #82297
Description
| BPO | 38116 |
|---|---|
| Nosy | @vstinner, @tiran, @phsilva, @DinoV, @ericsnowcurrently, @MojoVampire, @isidentical |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/DinoV'
closed_at = <Date 2020-06-22.09:14:47.516>
created_at = <Date 2019-09-11.14:48:15.345>
labels = ['extension-modules', 'type-feature', '3.9']
title = 'Make select module PEP-384 compatible'
updated_at = <Date 2020-06-22.09:28:51.858>
user = 'https://github.com/DinoV'bugs.python.org fields:
activity = <Date 2020-06-22.09:28:51.858>
actor = 'vstinner'
assignee = 'dino.viehland'
closed = True
closed_date = <Date 2020-06-22.09:14:47.516>
closer = 'vstinner'
components = ['Extension Modules']
creation = <Date 2019-09-11.14:48:15.345>
creator = 'dino.viehland'
dependencies = []
files = []
hgrepos = []
issue_num = 38116
keywords = ['patch']
message_count = 6.0
messages = ['351913', '352017', '352431', '356825', '372058', '372070']
nosy_count = 7.0
nosy_names = ['vstinner', 'christian.heimes', 'phsilva', 'dino.viehland', 'eric.snow', 'josh.r', 'BTaskaya']
pr_nums = ['15971']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue38116'
versions = ['Python 3.9']
Activity
DinoV commentedon Sep 11, 2019
Remove static PyTypeObject* definitions and move static data to _selectstate to help improve compatibility w/ subinterpreters and re-use by alternate implementations.
MojoVampire commentedon Sep 11, 2019
Why do you describe these issues (this one, bpo-38069, bpo-38071-bpo-38076, maybe more) as making the module PEP-384 compatible? There is no reason to make the built-in modules stick to the limited API, and it doesn't look like you're doing that in any event (among other things, pretty sure Argument Clinic generated code isn't limited API compatible yet, though that might be changing?).
Seems like the main (only?) change you're making is to convert all static types to dynamic types. Which is fine, if it's necessary for PEP-554, but it seems only loosely related to PEP-384 (which defined mechanisms for "statically" defining dynamic heap types, but that wasn't the main thrust).
DinoV commentedon Sep 14, 2019
New changeset f919054 by Dino Viehland in branch 'master':
bpo-38116: Convert select module to PEP-384 (bpo-15971)
f919054
isidentical commentedon Nov 17, 2019
PR 15971 is merged, what else is needed @dino.viehland?
vstinner commentedon Jun 22, 2020
Nothing, I close the issue.
vstinner commentedon Jun 22, 2020
I marked bpo-15703 as a duplicate of this issue.