Skip to content

importlib.metadata docs not showing up in the module index #81922

Closed

Description

@brettcannon
BPO 37741
Nosy @freddrake, @warsaw, @brettcannon, @jaraco, @hroncok, @miss-islington, @tirkarthi
PRs
  • bpo-37741: Make importlib.metadata a simple module #15153
  • [3.8] bpo-37741: Make importlib.metadata a simple module (GH-15153) #15154
  • bpo-37741: make importlib.metadata docs discoverable through a module directive. #25415
  • [3.9] bpo-37741: make importlib.metadata docs discoverable through a module directive. (GH-25415) #25417
  • [3.8] bpo-37741: make importlib.metadata docs discoverable through a module directive. (GH-25415) #25418
  • [3.9] bpo-37741: make importlib.metadata docs discoverable through a module directive. (GH-25415) #26500
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/warsaw'
    closed_at = <Date 2021-04-15.00:59:56.068>
    created_at = <Date 2019-08-01.18:47:05.826>
    labels = ['3.8', '3.9', '3.10', 'docs']
    title = 'importlib.metadata docs not showing up in the module index'
    updated_at = <Date 2021-06-27.22:05:30.764>
    user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2021-06-27.22:05:30.764>
    actor = 'jaraco'
    assignee = 'barry'
    closed = True
    closed_date = <Date 2021-04-15.00:59:56.068>
    closer = 'barry'
    components = ['Documentation']
    creation = <Date 2019-08-01.18:47:05.826>
    creator = 'brett.cannon'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 37741
    keywords = ['patch']
    message_count = 16.0
    messages = ['348872', '348874', '349060', '349062', '349063', '349090', '349134', '349137', '388729', '391097', '391102', '391115', '391116', '391117', '393975', '396607']
    nosy_count = 8.0
    nosy_names = ['fdrake', 'barry', 'brett.cannon', 'jaraco', 'docs@python', 'hroncok', 'miss-islington', 'xtreak']
    pr_nums = ['15153', '15154', '25415', '25417', '25418', '26500']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue37741'
    versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

    Activity

    1. brettcannon commented on Aug 1, 2019

      @brettcannon
      MemberAuthor

      If you look at https://docs.python.org/3.9/py-modindex.html#cap-i you will see that importlib.metadata isn't listed (same goes for the 3.8 docs).

      Or are you leaving it out due to it being provisional?

    2. freddrake commented on Aug 1, 2019

      @freddrake
      Member

      Provisional status should not cause a module or other API element to be omitted from the indexes. So long as it's marked provisional where it's described, it should be locatable.

    3. warsaw commented on Aug 5, 2019

      @warsaw
      Member

      There's an importlib.metadata.rst file which describes how to use the API, but that doesn't appear to be linked from either the main library ToC or the importlib documentation itself. I'll see if I can put together a PR to fix this.

    4. assigned and unassigned on Aug 5, 2019
    5. tirkarthi commented on Aug 5, 2019

      @tirkarthi
      Member

      Including a module directive with synopsis as below in importlib.metadata.rst seems to fix this. It would also be good to include a link to source code from the importlib.metadata docs page since it's written in Python.

      .. module:: importlib.metadata
      :synopsis: The implementation of the importlib metadata.

      **Source code:** :source:`Lib/importlib/metadata/init.py`

    6. warsaw commented on Aug 5, 2019

      @warsaw
      Member

      @jaraco - Why is the code in [Lib/importlib/metadata/__init__.py](https://github.com/python/cpython/blob/main/Lib/importlib/metadata/__init__.py) instead of [Lib/importlib/metadata.py](https://github.com/python/cpython/blob/main/Lib/importlib/metadata.py)? Is that to make it easier to port between CPython stdlib and the standalone version?

    7. jaraco commented on Aug 5, 2019

      @jaraco
      Member

      Why is the code in [Lib/importlib/metadata/__init__.py](https://github.com/python/cpython/blob/main/Lib/importlib/metadata/__init__.py)

      Mainly because originally, the code was in multiple modules. I'm happy for it to move into a single file module.

    8. brettcannon commented on Aug 6, 2019

      @brettcannon
      MemberAuthor

      If there's no porting benefit then let's move it to a single module instead of a package.

    9. warsaw commented on Aug 6, 2019

      @warsaw
      Member

      I’ll do a PR for that too.

      On Aug 6, 2019, at 14:07, Brett Cannon <report@bugs.python.org> wrote:

      Brett Cannon <brett@python.org> added the comment:

      If there's no porting benefit then let's move it to a single module instead of a package.

      ----------


      Python tracker <report@bugs.python.org>
      <https://bugs.python.org/issue37741\>


    10. hroncok commented on Mar 15, 2021

      hroncokmannequin
      Mannequin

      The docs at https://docs.python.org/3/library/importlib.metadata.html also don't list the API at all, it is just a tutorial, not a reference. I see the code has docstrings, but they are missing from the docs. E.g. PackageNotFoundError is not documented at all.

    11. brettcannon commented on Apr 14, 2021

      @brettcannon
      MemberAuthor

      Are you still planning to fix this, Barry?

    12. warsaw commented on Apr 14, 2021

      @warsaw
      Member

      I'd still like to. I'm also happy to review any PRs if someone beats me to it.

    13. miss-islington commented on Apr 15, 2021

      @miss-islington
      Contributor

      New changeset 23acadc by Jason R. Coombs in branch 'master':
      bpo-37741: make importlib.metadata docs discoverable through a module directive. (GH-25415)
      23acadc

    14. warsaw commented on Apr 15, 2021

      @warsaw
      Member

      @jaraco beat me to it. PRs approved!

    15. miss-islington commented on Apr 15, 2021

      @miss-islington
      Contributor

      New changeset a746fce by Miss Islington (bot) in branch '3.8':
      bpo-37741: make importlib.metadata docs discoverable through a module directive. (GH-25415)
      a746fce

    16. jaraco commented on May 19, 2021

      @jaraco
      Member

      New changeset ab1c3d9 by Miss Islington (bot) in branch '3.9':
      bpo-37741: make importlib.metadata docs discoverable through a module directive. (GH-25415) (GH-25417)
      ab1c3d9

    17. jaraco commented on Jun 27, 2021

      @jaraco
      Member

      New changeset 17b9167 by Jason R. Coombs in branch '3.9':
      [3.9] bpo-37741: make importlib.metadata docs discoverable through a module directive. (GH-25415) (GH-26500)
      17b9167

    18. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions