Skip to content

make unicodedata "const" #80823

Closed
Closed
make unicodedata "const"#80823
Labels
3.8 (EOL)end of lifetopic-unicode

Description

@methane
methane
opened on Apr 16, 2019
BPO 36642
Nosy @vstinner, @benjaminp, @ezio-melotti, @methane
PRs
  • bpo-36642: make unicodedata const #12855
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-04-16.23:40:49.529>
created_at = <Date 2019-04-16.12:49:58.548>
labels = ['3.8', 'expert-unicode']
title = 'make unicodedata "const"'
updated_at = <Date 2019-04-16.23:40:49.529>
user = 'https://github.com/methane'

    bugs.python.org fields:

    activity = <Date 2019-04-16.23:40:49.529>
actor = 'methane'
assignee = 'none'
closed = True
closed_date = <Date 2019-04-16.23:40:49.529>
closer = 'methane'
components = ['Unicode']
creation = <Date 2019-04-16.12:49:58.548>
creator = 'methane'
dependencies = []
files = []
hgrepos = []
issue_num = 36642
keywords = ['patch']
message_count = 3.0
messages = ['340336', '340337', '340372']
nosy_count = 4.0
nosy_names = ['vstinner', 'benjamin.peterson', 'ezio.melotti', 'methane']
pr_nums = ['12855']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36642'
versions = ['Python 3.8']

    Activity

    1. methane commented on Apr 16, 2019

      @methane
      methane
      on Apr 16, 2019
      MemberAuthor
      diff --git a/Tools/unicode/makeunicodedata.py b/Tools/unicode/makeunicodedata.py
index 9327693a17..2550b8f940 100644
--- a/Tools/unicode/makeunicodedata.py
+++ b/Tools/unicode/makeunicodedata.py
@@ -1249,7 +1249,7 @@ class Array:
         size = getsize(self.data)
         if trace:
             print(self.name+":", size*len(self.data), "bytes", file=sys.stderr)
-        file.write("static ")
+        file.write("static const ")
         if size == 1:
             file.write("unsigned char")
         elif size == 2:
    2. methane
      added
      3.8 (EOL)end of life
      topic-unicode
      on Apr 16, 2019

    3. vstinner commented on Apr 16, 2019

      @vstinner
      vstinner
      on Apr 16, 2019
      Member

      Can you write a PR?

    4. methane commented on Apr 16, 2019

      @methane
      methane
      on Apr 16, 2019
      MemberAuthor

      New changeset 6fec905 by Inada Naoki in branch 'master':
      bpo-36642: make unicodedata const (GH-12855)
      6fec905

    5. methane
      closed this as completedon Apr 16, 2019
    6. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.8 (EOL)end of lifetopic-unicode

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions