Repository navigation
_imp_create_dynamic_impl() does not clear error. #79657
Description
| BPO | 35476 |
|---|---|
| Nosy | @brettcannon, @ncoghlan, @ericsnowcurrently, @serhiy-storchaka, @isidentical |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2019-07-26.15:36:56.298>
created_at = <Date 2018-12-12.19:21:19.747>
labels = ['interpreter-core', '3.8', 'type-bug', '3.7']
title = '_imp_create_dynamic_impl() does not clear error.'
updated_at = <Date 2019-07-26.15:39:35.142>
user = 'https://github.com/ericsnowcurrently'bugs.python.org fields:
activity = <Date 2019-07-26.15:39:35.142>
actor = 'eric.snow'
assignee = 'none'
closed = True
closed_date = <Date 2019-07-26.15:36:56.298>
closer = 'eric.snow'
components = ['Interpreter Core']
creation = <Date 2018-12-12.19:21:19.747>
creator = 'eric.snow'
dependencies = []
files = []
hgrepos = []
issue_num = 35476
keywords = ['patch']
message_count = 6.0
messages = ['331717', '347809', '348200', '348212', '348493', '348494']
nosy_count = 5.0
nosy_names = ['brett.cannon', 'ncoghlan', 'eric.snow', 'serhiy.storchaka', 'BTaskaya']
pr_nums = ['14738']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue35476'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
Activity
ericsnowcurrently commentedon Dec 12, 2018
In _imp_create_dynamic_impl() [1] the case where _PyImport_FindExtensionObject() returns NULL may leave an error set. Either the error should be raised (like _imp_create_builtin() does) or it should be cleared (via PyErr_Clear()).
isidentical commentedon Jul 13, 2019
Can you give me the case so i can reproduce this and test it.
brettcannon commentedon Jul 19, 2019
Why would was want to swallow an exception? I think it would be better to let the exception propagate.
ncoghlan commentedon Jul 20, 2019
Agreed, raising the exception properly would be the way to go.
ericsnowcurrently commentedon Jul 26, 2019
Hmm, looks like this was already fixed by Serhiy (for bpo-35454) the day before I opened this issue. :)
3.8/master: #55286 8905fcc
3.7: #55314 62674f3
3.6: #55315 8855d93
That's what I get for not keeping my local clone up-to-date.
ericsnowcurrently commentedon Jul 26, 2019
Sorry, @batuhan. We appreciate your effort and would be glad to see more contributions from you. I hope you at least learned something positive while working on this. :)