Repository navigation
IDLE: Make TextView use the configured theme colors #78729
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/taleinat'
closed_at = <Date 2018-09-23.13:33:30.026>
created_at = <Date 2018-08-30.12:39:32.463>
labels = ['3.8', 'expert-IDLE', 'type-feature', '3.7']
title = 'IDLE: Make TextView use the configured theme colors'
updated_at = <Date 2018-09-23.16:38:19.781>
user = 'https://github.com/taleinat'bugs.python.org fields:
activity = <Date 2018-09-23.16:38:19.781>
actor = 'terry.reedy'
assignee = 'taleinat'
closed = True
closed_date = <Date 2018-09-23.13:33:30.026>
closer = 'taleinat'
components = ['IDLE']
creation = <Date 2018-08-30.12:39:32.463>
creator = 'taleinat'
dependencies = []
files = []
hgrepos = []
issue_num = 34548
keywords = ['patch']
message_count = 10.0
messages = ['326121', '326124', '326125', '326131', '326139', '326150', '326152', '326153', '326154', '326165']
nosy_count = 4.0
nosy_names = ['terry.reedy', 'taleinat', 'cheryl.sabella', 'miss-islington']
pr_nums = ['9008', '9513', '9514']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue34548'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
Activity
terryjreedy commentedon Sep 23, 2018
I am about to review and test, including live testing on Windows, with an eye to merging before the Monday midnight deadline for the coming releases. At the moment I have no personal preference, nor insight into likely user perferences.
Tal, what is your rationale for the proposal? Personal preference? Do you think a majority of user will prefer this? Have you hand-tested (or htested) on both Mac and Linux?
Cheryl, what do you think?
csabella commentedon Sep 23, 2018
I did a review on the PR which probably answers your question, but I'll summarize here.
I think consistency in the windows would be good. Consistency would include (but not limited to) foreground and background color, font style, font size, and behavior such as resizing. If a user has changed to a dark theme with a font size of 20, then opening up the help or find windows should use that.
So, I think this is a good suggestion, but I think it should be considered within a larger scope.
terryjreedy commentedon Sep 23, 2018
Investigating the code, I discovered that
# TODO: get fg/bg from theme."
is my rewrite on 2016 8 31, a3623c8, of
#elguavas - config placeholders til config stuff completed
Stephen Gava either wrote or modified the file in 2001. Using the config settings was the original intention, and I thought two years ago and in subsequent revisions that we should at least try it.
terryjreedy commentedon Sep 23, 2018
After live testing, I like 'after' at least as well as 'before'. I also decided that people who selects a dark theme because black on white is obnoxious to their eyes should have their choice on all text panes.
terryjreedy commentedon Sep 23, 2018
The first follow-up, bpo-34774, makes the help viewer use the current theme. It would be good if it were separately tested on Linux/Mac, as it uses multiple tags.
miss-islington commentedon Sep 23, 2018
New changeset c87d9f4 by Miss Islington (bot) (Tal Einat) in branch 'master':
bpo-34548: IDLE: use configured theme colors in TextView (GH-9008)
c87d9f4
miss-islington commentedon Sep 23, 2018
New changeset aeadf59 by Miss Islington (bot) in branch '3.7':
bpo-34548: IDLE: use configured theme colors in TextView (GH-9008)
aeadf59
miss-islington commentedon Sep 23, 2018
New changeset 6b48f98 by Miss Islington (bot) in branch '3.6':
bpo-34548: IDLE: use configured theme colors in TextView (GH-9008)
6b48f98
taleinat commentedon Sep 23, 2018
Thanks for the review, discussion and approval, Cheryl and Terry!
terryjreedy commentedon Sep 23, 2018
I removed 2.7 because I stopped routinely backporting to 2.7 some time ago because a) renaming files (which could not be backported) and using ttk widgets (ditto) made it much harder, and b) it was empirically too easy to introduce regressions without *thorough* hand testing. Given that most beginners now start with 3.x, I prefer merging more patches for current 3.x.