Skip to content

_datetime: Missing NULL check in tzinfo_from_isoformat_results() #78652

Closed

Description

@izbyshev
mannequin
BPO 34471
Nosy @abalkin, @benjaminp, @serhiy-storchaka, @pganssle, @izbyshev, @miss-islington
PRs
  • bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat… #8869
  • [3.7] closes bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat_results. (GH-8869) #8901
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-08-24.15:53:23.338>
    created_at = <Date 2018-08-23.10:14:40.927>
    labels = ['extension-modules', '3.8', 'type-bug', '3.7']
    title = '_datetime: Missing NULL check in tzinfo_from_isoformat_results()'
    updated_at = <Date 2018-08-24.16:14:01.901>
    user = 'https://github.com/izbyshev'

    bugs.python.org fields:

    activity = <Date 2018-08-24.16:14:01.901>
    actor = 'miss-islington'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-08-24.15:53:23.338>
    closer = 'benjamin.peterson'
    components = ['Extension Modules']
    creation = <Date 2018-08-23.10:14:40.927>
    creator = 'izbyshev'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 34471
    keywords = ['patch']
    message_count = 3.0
    messages = ['323934', '324005', '324006']
    nosy_count = 6.0
    nosy_names = ['belopolsky', 'benjamin.peterson', 'serhiy.storchaka', 'p-ganssle', 'izbyshev', 'miss-islington']
    pr_nums = ['8869', '8901']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue34471'
    versions = ['Python 3.7', 'Python 3.8']

    Activity

    1. izbyshev commented on Aug 23, 2018

      izbyshevmannequin
      MannequinAuthor

      The return value of new_delta() is not checked for NULL at

      PyObject *delta = new_delta(0, tzoffset, tz_useconds, 1);
      and then dereferenced.

      Reported by Svace static analyzer.

    2. benjaminp commented on Aug 24, 2018

      @benjaminp
      Contributor

      New changeset 4988453 by Benjamin Peterson (Alexey Izbyshev) in branch 'master':
      closes bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat_results. (GH-8869)
      4988453

    3. miss-islington commented on Aug 24, 2018

      @miss-islington
      Contributor

      New changeset c7f5435 by Miss Islington (bot) in branch '3.7':
      closes bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat_results. (GH-8869)
      c7f5435

    4. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.7 (EOL)end of life3.8 (EOL)end of lifeextension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions