Repository navigation
Make ndarray.readonly a bool #78382
Description
| BPO | 34201 |
|---|---|
| Nosy | @skrah, @serhiy-storchaka |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2018-07-26.11:26:19.270>
created_at = <Date 2018-07-23.14:01:22.566>
labels = ['3.8', 'type-feature', 'tests']
title = 'Make ndarray.readonly a bool'
updated_at = <Date 2018-07-26.13:14:25.443>
user = 'https://github.com/serhiy-storchaka'bugs.python.org fields:
activity = <Date 2018-07-26.13:14:25.443>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2018-07-26.11:26:19.270>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2018-07-23.14:01:22.566>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 34201
keywords = ['patch']
message_count = 2.0
messages = ['322221', '322412']
nosy_count = 2.0
nosy_names = ['skrah', 'serhiy.storchaka']
pr_nums = ['8414', '8481']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue34201'
versions = ['Python 3.8']
Activity
serhiy-storchaka commentedon Jul 23, 2018
memoryview.readonly is a bool, but ndarray.readonly is an int 0 or 1. The proposed PR makes ndarray.readonly a bool and makes test_buffer using more strict assertIs() instead of assertEqual() for testing boolean values.
serhiy-storchaka commentedon Jul 26, 2018
New changeset e0d67f1 by Serhiy Storchaka in branch 'master':
bpo-34201: Make ndarray.readonly a bool and use stricter tests in test_buffer. (GH-8414)
e0d67f1