Skip to content

asyncio: transports don't support switching between Protocol and BufferedProtocol #77835

Closed
Closed
asyncio: transports don't support switching between Protocol and BufferedProtocol#77835
Assignees
1st1
Labels
3.7 (EOL)end of life3.8 (EOL)end of lifetopic-asynciotype-bugAn unexpected behavior, bug, or error

Description

@1st1
1st1
opened on May 26, 2018
BPO 33654
Nosy @ned-deily, @asvetlov, @1st1, @miss-islington
PRs
  • bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() #7130
  • [3.7] bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (GH-7130) #7164
  • bpo-33654: Support protocol type switching in SSLTransport.set_protocol() #7194
  • [3.7] bpo-33654: Support protocol type switching in SSLTransport.set_protocol() (GH-7194) #7198
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/1st1'
closed_at = <Date 2018-05-28.19:14:06.583>
created_at = <Date 2018-05-26.17:08:31.631>
labels = ['3.8', 'type-bug', '3.7', 'expert-asyncio']
title = "asyncio: transports don't support switching between Protocol and BufferedProtocol"
updated_at = <Date 2018-05-29.09:19:15.519>
user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2018-05-29.09:19:15.519>
actor = 'miss-islington'
assignee = 'yselivanov'
closed = True
closed_date = <Date 2018-05-28.19:14:06.583>
closer = 'yselivanov'
components = ['asyncio']
creation = <Date 2018-05-26.17:08:31.631>
creator = 'yselivanov'
dependencies = []
files = []
hgrepos = []
issue_num = 33654
keywords = ['patch']
message_count = 8.0
messages = ['317743', '317745', '317748', '317750', '317897', '317900', '317990', '317994']
nosy_count = 4.0
nosy_names = ['ned.deily', 'asvetlov', 'yselivanov', 'miss-islington']
pr_nums = ['7130', '7164', '7194', '7198']
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33654'
versions = ['Python 3.7', 'Python 3.8']

    Activity

    1. 1st1 commented on May 26, 2018

      @1st1
      1st1
      on May 26, 2018
      MemberAuthor

      1. asyncio.BufferedProtocol is a new Python 3.7 *provisional* API.

      2. asyncio.Transport.set_protocol() doesn't support switching between Protocol and BufferedProtocol.

      3. Because of (2), another *new* Python 3.7 API "loop.start_tls" doesn't support asyncio.BufferedProtocol at all.

      The fix is straightforward and *does not* affect any existing APIs in Python 3.6 and lower. Since the patch adjusts the APIs a little bit, it would be great to merge this in 3.7.0.

      However, since only the provisional APIs are changed, this can be theoretically merged to 3.7.1 too. It would be nice, though, to get this into 3.7.0. Ned, your thoughts?

    2. 1st1
      added
      3.7 (EOL)end of life
      3.8 (EOL)end of life
      on May 26, 2018
    3. 1st1
      self-assigned this
      on May 26, 2018
    4. 1st1
      added
      topic-asyncio
      on May 26, 2018

    5. 1st1 commented on May 26, 2018

      @1st1
      1st1
      on May 26, 2018
      MemberAuthor

      Setting "release blocker" to get Ned's attention.

    6. 1st1
      added
      release-blocker
      on May 26, 2018

    7. ned-deily commented on May 26, 2018

      @ned-deily
      ned-deily
      on May 26, 2018
      Member

      LGTM for 3.7

    8. ned-deily
      removed
      release-blocker
      on May 26, 2018

    9. 1st1 commented on May 26, 2018

      @1st1
      1st1
      on May 26, 2018
      MemberAuthor

      Thanks, Ned!

    10. 1st1 commented on May 28, 2018

      @1st1
      1st1
      on May 28, 2018
      MemberAuthor

      New changeset dbf1022 by Yury Selivanov in branch 'master':
      bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (GH-7130)
      dbf1022

    11. miss-islington commented on May 28, 2018

      @miss-islington
      miss-islington
      on May 28, 2018
      Contributor

      New changeset bc3a002 by Miss Islington (bot) in branch '3.7':
      bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (GH-7130)
      bc3a002

    12. 1st1
      closed this as completedon May 28, 2018
    13. 1st1
      added
      type-bugAn unexpected behavior, bug, or error
      on May 28, 2018

    14. asvetlov commented on May 29, 2018

      @asvetlov
      asvetlov
      on May 29, 2018
      Contributor

      New changeset 2179022 by Andrew Svetlov (Yury Selivanov) in branch 'master':
      bpo-33654: Support protocol type switching in SSLTransport.set_protocol() (bpo-7194)
      2179022

    15. miss-islington commented on May 29, 2018

      @miss-islington
      miss-islington
      on May 29, 2018
      Contributor

      New changeset be5d616 by Miss Islington (bot) in branch '3.7':
      bpo-33654: Support protocol type switching in SSLTransport.set_protocol() (GH-7194)
      be5d616

    16. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    Labels

    3.7 (EOL)end of life3.8 (EOL)end of lifetopic-asynciotype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions